Add strpos function as a synonym for position#35009
Open
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Open
Add strpos function as a synonym for position#35009ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
strpos function as a synonym for position#35009ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
antiguru
approved these changes
Feb 13, 2026
src/expr/src/scalar/func.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[sqlfunc(propagates_nulls = true)] |
Member
There was a problem hiding this comment.
Suggested change
| #[sqlfunc(propagates_nulls = true)] | |
| #[sqlfunc] |
Propagates nulls is inferred from the parameters, none can handle null values.
Contributor
Author
There was a problem hiding this comment.
Ok, thanks! Then I'm also deleting propagates_nulls = true from position.
ggevay
force-pushed
the
strpos
branch
2 times, most recently
from
46a59e3 to
df94f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PowerBI wants to use this, see
https://materializeinc.slack.com/archives/CU7ELJ6E9/p1771014597562589?thread_ts=1770243087.325139&cid=CU7ELJ6E9
(This was almost a one-shot from my AI agent, with the prompt pointing it to
position's implementation.)