Skip to content

Make CollectionLookupError returns more precise#35011

Open
ggevay wants to merge 2 commits intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-2
Open

Make CollectionLookupError returns more precise#35011
ggevay wants to merge 2 commits intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-2

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Feb 13, 2026

This is a refactoring related to the frontend peek sequencing, addressing the second paragraph of #33713 (comment) + other related discussions with Moritz and Jan.

This PR makes many function return types specify more precise error types. This made CollectionLookupError used only by PeekClient, so it was moved there.

Part 2 of 3 from the original #34839. Depends on #35010.

@github-actions
Copy link

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ggevay ggevay marked this pull request as ready for review February 13, 2026 22:01
@ggevay ggevay requested review from a team as code owners February 13, 2026 22:01
@ggevay ggevay requested a review from mtabebe February 13, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant