Don't allow to write deprecated elements#156
Draft
robUx4 wants to merge 6 commits intoMatroska-Org:masterfrom
Draft
Don't allow to write deprecated elements#156robUx4 wants to merge 6 commits intoMatroska-Org:masterfrom
robUx4 wants to merge 6 commits intoMatroska-Org:masterfrom
Conversation
We can then put WebM and DivX information
It's cleaner than overriding RenderData and returning 0 and it doesn't return the same value as UpdateSize().
robUx4
added
api-break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #148, only the last 2 commits matter here.
Requires Matroska-Org/libebml#207 and Matroska-Org/libebml#210
The RenderData hack is dirty and likely bogus. This uses the write filter calls to always disable the element when trying to write it.
We actually override the
CanWrite()method more often (all Matroska elements) than we overrideRenderData(). Maybe using an interface with multiple class inheritance could avoid this and have one implementation for all of them...