Created CommonJS, ESM, and AMD outputs.#5
Open
shanewholloway wants to merge 2 commits intoMattasher:masterfrom
Open
Created CommonJS, ESM, and AMD outputs.#5shanewholloway wants to merge 2 commits intoMattasher:masterfrom
shanewholloway wants to merge 2 commits intoMattasher:masterfrom
Conversation
…age version due to compatibility break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for making probability-distributions package!
This pull request uses Rollup to create alternative outputs. The
"main"entrypoint is equivalent to what you had published to date. The"module"entrypoint (.esm.mjs) allows packagers to selectively assemble modules by pulling only the needed functions. (See treeshaking in Rollup and WebPack.) In my case, I wanted to use only thePD.rnorm()Gaussian Normal function.The second change replaces the use of
eval()with a callback, enabling the expressed intent without the security issues involved with eval.The unit tests all pass. Thanks for creating them! If you'd like to try before you merge, you can use
npm install --save github:shanewholloway/probability-distributions