Fixed LobbyMetadata Overflowing and Causing Errors#79
Merged
Hidden character warning
The head ref may contain hidden characters: "lobby-metadata-"fix""
Conversation
Added a sort to help make sure the Everyone requirement plugins are higher priority when converting to JSON. Also made a modifiable max lobby metadata string length for any mods that may require more metadata.
MaxWasUnavailable
previously requested changes
Mar 9, 2025
Owner
MaxWasUnavailable
left a comment
MaxWasUnavailable
left a comment
There was a problem hiding this comment.
Left two comments for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lobby Metadata has a maximum length of 8192 characters - for all metadata (not per entry). We were running into this limit when many mods were installed, so this should limit it to the maximum allowed.
I added sorting for it so that the stricter compatibility requirements are prioritized before other mods.
I also added a way for other mods to reduce the maximum allowed metadata length in case they need more metadata space than we allotted for.