Skip to content

Fix recognition correctness regressions - #1

Merged
Maxello1 merged 1 commit into
mainfrom
codex/recognition-correctness
Jul 12, 2026
Merged

Fix recognition correctness regressions#1
Maxello1 merged 1 commit into
mainfrom
codex/recognition-correctness

Conversation

@Maxello1

Copy link
Copy Markdown
Owner

Summary

  • distinguish circular rings from polygonal Light geometry while preserving stroke boundaries
  • complete Light, ring-shape, incomplete-Light, Earth + Levitation ×3, and messy multi-symbol coverage
  • fix Wind/Column candidate segmentation and reject symmetric diamond matches for Convergence
  • store raw strokes through the production spell-stack updater

Root cause

Ring fitting accepted polygon-like closed strokes; candidate grouping fragmented detached Wind accents; point-cloud matching lacked completeness and closed-shape structure checks; raw strokes were updated outside the reusable stack helper.

Impact

Light's square remains part of the sigil, complete Light selects the real circle, canonical multisets/determinism/noise/super-candidate behavior remain protected, and valid stored spells cannot survive an invalid redraw.

Validation

  • JAVA_HOME=C:\Users\karl-\.jdks\jdk-25.0.3+9 .\gradlew clean build test
  • 51 tests passed
  • canonical metrics: 15/15 positives, 0/13 false positives, 0 false rejections

Known follow-up

The in-game debug overlay can still show an unknown candidate around the ring, and simple Column drawings may miss recognition. These are deferred to the next recognition roadmap.

@Maxello1
Maxello1 marked this pull request as ready for review July 12, 2026 23:42
@Maxello1
Maxello1 merged commit c2e8a8b into main Jul 12, 2026
2 checks passed
@Maxello1
Maxello1 deleted the codex/recognition-correctness branch July 12, 2026 23:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0def7e0b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant