feat(storage): add SQLite vector store, VectorStore protocol, and tests#1
Open
MbappeWU wants to merge 1 commit intoclaude/add-claude-documentation-kYGTjfrom
Open
feat(storage): add SQLite vector store, VectorStore protocol, and tests#1MbappeWU wants to merge 1 commit intoclaude/add-claude-documentation-kYGTjfrom
MbappeWU wants to merge 1 commit intoclaude/add-claude-documentation-kYGTjfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
InMemoryVectorStorevs SQLite).Description
VectorStoreprotocol and serialization helpers withdumps_vector,loads_vector,dumps_payload, andloads_payloadinsrc/memomind/storage/.SqliteVectorStoreas a SQLite-backed implementation that persists serialized vectors and payloads and usescosine_similarityfor scoring.InMemoryVectorStoreand refactorMemoryStoreto accept a pluggableVectorStorebackend and upsert embeddings with apayloadsummary.README.md,docs/SPEC.md,docs/ARCHITECTURE.md,pyproject.toml) and add.gitignorefor common files.Testing
pytestafter addingtests/conftest.pyto ensure the test runner can import thesrcpath; the test suite collected 2 items and2 passed.tests/test_vector_store.pywhich verifiesInMemoryVectorStoreordering and thatSqliteVectorStorepersists and returns the inserted record.Codex Task