Open
Conversation
…d line from another user
_functions/translate.py
Outdated
Owner
There was a problem hiding this comment.
You appear to have removed the space in-between the " ", since this is the string joining the message parts the translation fails.
The nonTranslated string also needs to be URL encoded before passing it on to requests.
_functions/translate.py
Outdated
Owner
There was a problem hiding this comment.
This causes a NameError: global name 'langList' is not defined exception.
The syntax and langList variables need to be referenced with self.langList or self.syntax since they belong to the class.
On the unicode and utf-8 thing for .sendMsg, would changing str(translated) to translated.decode('utf-8') work? Im confused
--amend for github browser mode pls
_functions/translate.py
Outdated
Owner
There was a problem hiding this comment.
This should probably be checked against jsonObj["responseDetails"] instead of jsonObj["responseData"]["translatedText"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: Allow to translate last typed line from another user