fix: center Settings rows, refresh added peripherals, and surface release errors - #46
Merged
Merged
Conversation
…ease errors - Drop the nested List inside the Form sections so the Form lays out the rows and keeps their content vertically centered (Registered/Available Peripherals, Connected/Available Devices). The nested List gave short rows a taller default height, which top-aligned their content. - Resolve a newly added peripheral's live connection state (and register its disconnect observer) immediately, instead of showing it as disconnected until the tab is reopened. - Rename the connected-state peripheral button from "Disconnect" to "Release". - Surface the per-peripheral operation error inline in the Settings Peripheral tab, mirroring the menu-bar dropdown. The store already auto-fades it after 5s, so there's no extra state to manage.
|
🎉 This PR is included in version 2.14.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI polish for the Settings Peripheral and Device tabs (plus one related store fix).
Listinside theFormsections so theFormlays out the rows directly and keeps their content vertically centered — Registered/Available Peripherals and Connected/Available Devices. The nestedListgave short rows a taller default height, which top-aligned their content (the "JJJJ… sits high in the pill" issue).Notes
swift format-clean; builds withCODE_SIGNING_ALLOWED=NO.Testing
Built and run locally (Debug). Verified in the running app: rows are centered in all four sections; adding an already-connected peripheral immediately shows Release; a failing Release/Connect surfaces the inline error for ~5s and then clears.