feat: add custom CLI arguments for Multus CNI #2148
Draft
e0ne wants to merge 2 commits intoMellanox:masterfrom
Draft
feat: add custom CLI arguments for Multus CNI #2148e0ne wants to merge 2 commits intoMellanox:masterfrom
e0ne wants to merge 2 commits intoMellanox:masterfrom
Conversation
Extends MultusSpec with optional CliArgs field to allow passing custom command-line arguments to Multus CNI, enabling more flexible Multus configuration. Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Adds argument merging functionality to allow CliArgs to extend or override default Multus CNI arguments. The implementation builds default args with runtime values, merges with user-provided CliArgs (with CliArgs taking precedence), and passes the merged list to the DaemonSet template. Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
adrianchiris
reviewed
Feb 9, 2026
| return arg | ||
| } | ||
|
|
||
| // mergeMultusArgs merges default args with custom CliArgs, allowing CliArgs to override defaults. |
Collaborator
There was a problem hiding this comment.
what if i want to remove an arg ?
maybe its better to:
- have default set of args
- if user provides args we use that (no merging)
Collaborator
Author
There was a problem hiding this comment.
I agree, that's simplifies implementation and adds more flexibility. I'll update my pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.