ci: update k8snetworkplumbingwg-plugins version to 32846185 (of branch network-operator-26.4.x)#2249
Conversation
Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
Greptile SummaryThis automated CI PR bumps the Key issue found:
Confidence Score: 2/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[hack/release.yaml\nversion quoted correctly] -->|automated CI bump| B[Example CR YAMLs]
B --> C[cr.yaml\nversion unquoted integer]
B --> D[cr-full.yaml\nversion unquoted integer]
B --> E[cr-ipoib.yaml\nversion unquoted integer]
B --> F[cr-nvidia-ipam.yaml\nversion unquoted integer]
C --> G[CRD expects type string\nValidation fails]
D --> G
E --> G
F --> G
Last reviewed commit: cddfaf4 |
| image: plugins | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: network-operator-v26.1.0 | ||
| version: 32846185 |
There was a problem hiding this comment.
Unquoted numeric version will be parsed as YAML integer
The value 32846185 without quotes is parsed by YAML as an integer, not a string. The NicClusterPolicy CRD (config/crd/bases/mellanox.com_nicclusterpolicies.yaml) defines version as type: string. Submitting this YAML as-is will likely cause a Kubernetes CRD validation failure because an integer is provided where a string is expected.
Note that hack/release.yaml correctly quotes this same value as "32846185". The same fix is needed in all four example CR files:
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml:68example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yamlexample/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yamlexample/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml
| version: 32846185 | |
| version: "32846185" |
| image: plugins | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: network-operator-v26.1.0 | ||
| version: 32846185 |
There was a problem hiding this comment.
Unquoted numeric version will be parsed as YAML integer
Same issue as in mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml — 32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.
| version: 32846185 | |
| version: "32846185" |
| image: plugins | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: network-operator-v26.1.0 | ||
| version: 32846185 |
There was a problem hiding this comment.
Unquoted numeric version will be parsed as YAML integer
Same issue as in the other example CRs — 32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.
| version: 32846185 | |
| version: "32846185" |
| image: plugins | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: network-operator-v26.1.0 | ||
| version: 32846185 |
There was a problem hiding this comment.
Unquoted numeric version will be parsed as YAML integer
Same issue as in the other example CRs — 32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.
| version: 32846185 | |
| version: "32846185" |
Automated CI update for component 'k8snetworkplumbingwg-plugins', created by GitHub actions reusable workflow run 22899428503 for release branch network-operator-26.4.x.