Skip to content

ci: update k8snetworkplumbingwg-plugins version to 32846185 (of branch network-operator-26.4.x)#2249

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-k8snetworkplumbingwg-plugins-version-to-32846185
Open

ci: update k8snetworkplumbingwg-plugins version to 32846185 (of branch network-operator-26.4.x)#2249
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-k8snetworkplumbingwg-plugins-version-to-32846185

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for component 'k8snetworkplumbingwg-plugins', created by GitHub actions reusable workflow run 22899428503 for release branch network-operator-26.4.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Mar 10, 2026

Greptile Summary

This automated CI PR bumps the k8snetworkplumbingwg-plugins (CniPlugins) component version from network-operator-v26.1.0 to 32846185 (a commit SHA / build number from the network-operator-26.4.x branch) across hack/release.yaml and four example NicClusterPolicy CRs.

Key issue found:

  • In hack/release.yaml, the new version is correctly quoted as "32846185" (YAML string). However, in all four example CR files the value is written unquoted as 32846185, which YAML parsers interpret as an integer. The NicClusterPolicy CRD schema (config/crd/bases/mellanox.com_nicclusterpolicies.yaml) defines version as type: string, so applying these example CRs would trigger a Kubernetes CRD validation error. All four example files need the value quoted: version: "32846185".

Confidence Score: 2/5

  • Not safe to merge as-is — all four example CRs use an unquoted integer for version, which will fail CRD string validation when applied.
  • The core version bump in hack/release.yaml is correct and properly quoted. However, the automated tooling failed to quote the numeric-only version string in the four example CR YAML files, leaving them with a YAML integer where the CRD schema requires a string. This will cause kubectl apply failures for anyone using these examples.
  • All four files under example/crs/ need the version value quoted: version: "32846185".

Important Files Changed

Filename Overview
hack/release.yaml CniPlugins version bumped from network-operator-v26.1.0 to "32846185" (correctly quoted as a string).
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml cniPlugins version updated to 32846185 but is unquoted — YAML parses it as an integer, which will fail CRD string validation.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml Same unquoted integer version issue as cr.yaml32846185 needs to be "32846185".
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml Same unquoted integer version issue — 32846185 needs to be quoted as "32846185".
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml Same unquoted integer version issue — 32846185 needs to be quoted as "32846185".

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[hack/release.yaml\nversion quoted correctly] -->|automated CI bump| B[Example CR YAMLs]
    B --> C[cr.yaml\nversion unquoted integer]
    B --> D[cr-full.yaml\nversion unquoted integer]
    B --> E[cr-ipoib.yaml\nversion unquoted integer]
    B --> F[cr-nvidia-ipam.yaml\nversion unquoted integer]
    C --> G[CRD expects type string\nValidation fails]
    D --> G
    E --> G
    F --> G
Loading

Last reviewed commit: cddfaf4

image: plugins
repository: nvcr.io/nvstaging/mellanox
version: network-operator-v26.1.0
version: 32846185
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted numeric version will be parsed as YAML integer

The value 32846185 without quotes is parsed by YAML as an integer, not a string. The NicClusterPolicy CRD (config/crd/bases/mellanox.com_nicclusterpolicies.yaml) defines version as type: string. Submitting this YAML as-is will likely cause a Kubernetes CRD validation failure because an integer is provided where a string is expected.

Note that hack/release.yaml correctly quotes this same value as "32846185". The same fix is needed in all four example CR files:

  • example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml:68
  • example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml
  • example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml
  • example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml
Suggested change
version: 32846185
version: "32846185"

image: plugins
repository: nvcr.io/nvstaging/mellanox
version: network-operator-v26.1.0
version: 32846185
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted numeric version will be parsed as YAML integer

Same issue as in mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.

Suggested change
version: 32846185
version: "32846185"

image: plugins
repository: nvcr.io/nvstaging/mellanox
version: network-operator-v26.1.0
version: 32846185
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted numeric version will be parsed as YAML integer

Same issue as in the other example CRs — 32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.

Suggested change
version: 32846185
version: "32846185"

image: plugins
repository: nvcr.io/nvstaging/mellanox
version: network-operator-v26.1.0
version: 32846185
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted numeric version will be parsed as YAML integer

Same issue as in the other example CRs — 32846185 is parsed as a YAML integer, but the CRD schema requires a string. Please quote it consistently with hack/release.yaml.

Suggested change
version: 32846185
version: "32846185"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant