Skip to content

ci: update rdma-cni version to 3a26f69 (of branch network-operator-26.4.x)#2265

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-rdma-cni-version-to-3a26f69
Open

ci: update rdma-cni version to 3a26f69 (of branch network-operator-26.4.x)#2265
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-rdma-cni-version-to-3a26f69

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for component 'rdma-cni', created by GitHub actions reusable workflow run 23273566552 for release branch network-operator-26.4.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Mar 19, 2026

Greptile Summary

This is an automated CI PR that updates the rdma-cni component version in both deployment/network-operator/values.yaml and hack/release.yaml from the release tag network-operator-v26.1.0 to the short git commit SHA 3a26f69, sourced from the network-operator-26.4.x branch of the rdma-cni repository.

Key observations:

  • The two changed files are consistent with each other — both point rdmaCni to 3a26f69.
  • All other components in both files continue to use the structured network-operator-v26.x.x version tag format; rdmaCni is the only component using a raw commit SHA, which is a versioning inconsistency worth noting.
  • This appears to be intentional automation (triggered by a GitHub Actions reusable workflow run), likely pinning a pre-release commit before a formal 26.4.x release tag is cut.

Confidence Score: 4/5

  • This PR is generally safe to merge — it is a targeted, automated version bump with no logic changes. The only concern is the use of a raw commit SHA instead of a proper release tag, which is a style/traceability issue rather than a functional one.
  • The change is minimal and automated: two files, one field each, both consistently updated. The image at tag 3a26f69 should exist in the staging registry as produced by the upstream CI workflow. The sole deduction is the use of an unversioned commit SHA (3a26f69) instead of a semver-style tag, making the release version harder to audit compared to all other components in the same files.
  • No files require special attention beyond the noted versioning inconsistency in deployment/network-operator/values.yaml and hack/release.yaml.

Important Files Changed

Filename Overview
deployment/network-operator/values.yaml Updates rdmaCni image tag from network-operator-v26.1.0 to the raw commit SHA 3a26f69, creating a versioning inconsistency with all other components in the block.
hack/release.yaml Updates rdmaCni version from network-operator-v26.1.0 to the raw commit SHA 3a26f69, consistent with the values.yaml change but inconsistent with all other components which use semantic version tags.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Automation\nnvidia-ci-cd] -->|Triggers automated update| B[PR #2265]
    B --> C{Files Updated}
    C --> D[deployment/network-operator/values.yaml\nrdmaCni tag: network-operator-v26.1.0 → 3a26f69]
    C --> E[hack/release.yaml\nrdmaCni version: network-operator-v26.1.0 → 3a26f69]
    D --> F[nvcr.io/nvstaging/mellanox/rdma-cni:3a26f69]
    E --> F
    F --> G[Deployed rdma-cni image\nCommit SHA pinned]
Loading

Last reviewed commit: "ci: update rdma-cni ..."

ibSriovCni: nvcr.io/nvstaging/mellanox/ib-sriov-cni:network-operator-v26.1.0
ovsCni: nvcr.io/nvstaging/mellanox/ovs-cni-plugin:network-operator-v26.1.0
rdmaCni: nvcr.io/nvstaging/mellanox/rdma-cni:network-operator-v26.1.0
rdmaCni: nvcr.io/nvstaging/mellanox/rdma-cni:3a26f69
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Raw commit SHA used instead of versioned tag

The rdmaCni image tag is being set to 3a26f69, a short git commit SHA, while every other component in this same block uses a consistent, human-readable version tag (network-operator-v26.1.0). This inconsistency makes it harder to audit what version is deployed, compare component versions at a glance, or trace back to a release. The same pattern applies in hack/release.yaml line 120.

If a proper release tag is not yet available for this component, it may be worth tracking the missing tag as a follow-up. If this is intentional as a temporary CI pin, a comment noting that would help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant