Skip to content

ci: update dra-driver-sriov version to 2a1db41 (of branch network-operator-26.4.x)#2269

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-dra-driver-sriov-version-to-2a1db41
Open

ci: update dra-driver-sriov version to 2a1db41 (of branch network-operator-26.4.x)#2269
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-dra-driver-sriov-version-to-2a1db41

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for component 'dra-driver-sriov', created by GitHub actions reusable workflow run 23323299298 for release branch network-operator-26.4.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This automated CI PR updates the DraDriverSriov component version in hack/release.yaml from network-operator-v26.1.0 to 2a1db41 (a short commit SHA), targeting the master branch on behalf of the network-operator-26.4.x release branch.

  • The version is pinned to a raw 7-character commit SHA (2a1db41) rather than a named semantic version tag, which is inconsistent with the convention used by every other component in the file (e.g., network-operator-v26.1.0, v25.10.0)
  • This reduces traceability and makes it harder to audit or reproduce builds compared to a stable named tag
  • No other functional code changes are made; the impact is limited to build/release tooling that consumes hack/release.yaml

Confidence Score: 3/5

  • Merge is low-risk but introduces a versioning inconsistency by using a raw commit SHA instead of a named tag.
  • The change is a single-line automated bump confined to release metadata. The only concern is the deviation from the established naming convention (network-operator-vX.Y.Z tags) used by every other component, which may indicate the upstream tag has not been cut yet and this SHA is a temporary reference.
  • hack/release.yaml — specifically the DraDriverSriov.version field which uses a raw commit SHA

Important Files Changed

Filename Overview
hack/release.yaml Updates DraDriverSriov version from network-operator-v26.1.0 (a named tag) to 2a1db41 (a raw short commit SHA), which is inconsistent with the versioning convention used by all other components in the file.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GitHub Actions Workflow\nnetwork-operator-26.4.x branch] -->|triggers automated CI PR| B[PR #2269\ntargets master]
    B --> C[hack/release.yaml\nDraDriverSriov.version]
    C --> D{Version Format}
    D -->|Before| E["network-operator-v26.1.0\n(named semantic tag)"]
    D -->|After| F["2a1db41\n(raw commit SHA)"]
    F --> G[Build/Release tooling\nconsumes release.yaml]
    G --> H[nvcr.io/nvstaging/mellanox/dra-driver-sriov:2a1db41]
Loading

Last reviewed commit: "ci: update dra-drive..."

repository: nvcr.io/nvstaging/mellanox
sourceRepository: dra-driver-sriov
version: network-operator-v26.1.0
version: 2a1db41
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version uses raw commit SHA instead of semantic tag

All other components in this file use named version tags (e.g., network-operator-v26.1.0, v25.10.0, network-operator-v26.1.0-stig-fips), but DraDriverSriov is now pinned to a raw 7-character commit SHA 2a1db41. This makes it harder to understand which release this corresponds to, undermines traceability in CI/CD pipelines, and may cause confusion when auditing or reproducing builds.

If this is a deliberate pre-release/interim bump before a proper tag is cut on the network-operator-26.4.x branch, it should be documented. Otherwise, consider waiting until a proper tag (e.g., network-operator-v26.4.0) is available on the source branch and using that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant