Skip to content

ci: update k8snetworkplumbingwg-plugins version to 5f263ea0 (of branch network-operator-26.4.x)#2270

Closed
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-k8snetworkplumbingwg-plugins-version-to-5f263ea0
Closed

ci: update k8snetworkplumbingwg-plugins version to 5f263ea0 (of branch network-operator-26.4.x)#2270
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-k8snetworkplumbingwg-plugins-version-to-5f263ea0

Conversation

@nvidia-ci-cd
Copy link
Copy Markdown
Collaborator

Automated CI update for component 'k8snetworkplumbingwg-plugins', created by GitHub actions reusable workflow run 23323590150 for release branch network-operator-26.4.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Mar 20, 2026

Greptile Summary

This is an automated CI bump that updates the k8snetworkplumbingwg-plugins (CniPlugins) component version from network-operator-v26.1.0 to 5f263ea0 across the release manifest and all four example NicClusterPolicy CRs. The change is internally consistent — all five files that reference this component have been updated to the same value.

Key observations:

  • The new version 5f263ea0 is an 8-character short git commit SHA, not a named release tag. Every other component in hack/release.yaml and the example CRs uses a descriptive semantic tag (e.g. network-operator-v26.1.0). This inconsistency may indicate the upstream k8snetworkplumbingwg-plugins build for the network-operator-26.4.x release branch has not yet been formally tagged.
  • The PR targets master but the triggering workflow references the network-operator-26.4.x release branch, suggesting this is a forward-port or pre-release tracking update. It is worth confirming this is intentional before merging.
  • All five changed files are modified in lock-step, so there are no partial-update issues.

Confidence Score: 4/5

  • This PR is safe to merge with a minor caveat around the non-standard version format used for CniPlugins.
  • The change is a simple, automated, and internally consistent version bump across 5 files. The only concern is that the new version is a short git commit SHA rather than a named release tag, which is inconsistent with every other component and could complicate traceability. There are no logic errors, security issues, or missing updates.
  • hack/release.yaml — the sole authoritative version source; the short SHA format inconsistency should be verified before merging to master.

Important Files Changed

Filename Overview
hack/release.yaml Updates CniPlugins.version from network-operator-v26.1.0 to the short git commit SHA 5f263ea0, while all other components retain a named semantic version tag.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml Updates cniPlugins.version under secondaryNetwork from network-operator-v26.1.0 to 5f263ea0 to match the new CI-pinned commit hash.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml Updates cniPlugins.version from network-operator-v26.1.0 to 5f263ea0, consistent with the rest of the PR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml Updates cniPlugins.version from network-operator-v26.1.0 to 5f263ea0, consistent with the rest of the PR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml Updates cniPlugins.version from network-operator-v26.1.0 to 5f263ea0, consistent with the rest of the PR.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["GitHub Actions Workflow\n(network-operator-26.4.x)"] -->|"triggers automated PR"| B["PR #2270\nnvidia-ci-cd bot"]
    B --> C["hack/release.yaml\nCniPlugins.version:\nnetwork-operator-v26.1.0 → 5f263ea0"]
    B --> D["example/crs/*.yaml\ncniPlugins.version:\nnetwork-operator-v26.1.0 → 5f263ea0"]
    C --> E["4 example CR files\nupdated in sync"]
    D --> E
    E --> F["Container image pulled:\nnvcr.io/nvstaging/mellanox/plugins:5f263ea0"]
    style F fill:#ffe4b5,stroke:#d4a017
    style C fill:#d4edda,stroke:#28a745
    style D fill:#d4edda,stroke:#28a745
Loading

Last reviewed commit: "ci: update k8snetwor..."

Comment thread hack/release.yaml
repository: nvcr.io/nvstaging/mellanox
sourceRepository: k8snetworkplumbingwg-plugins
version: network-operator-v26.1.0
version: 5f263ea0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Short commit SHA used instead of a named version tag

Every other component in this file uses a descriptive, human-readable version tag (e.g. network-operator-v26.1.0), but CniPlugins is now pinned to a raw 8-character short SHA (5f263ea0). Short SHAs can become ambiguous as a repository grows, are harder to reason about in changelogs or incident response, and are inconsistent with the versioning convention used across the rest of this file.

If the k8snetworkplumbingwg-plugins build for the network-operator-26.4.x branch has not yet been tagged, it would be worth checking whether a proper tag (network-operator-v26.4.x or similar) has been (or will be) published before this lands on master, and updating the version accordingly. If using a commit SHA is intentional for this pre-release CI flow, a brief comment in release.yaml explaining the exception would help future maintainers.

The same version string is also mirrored in all four example CR files, so they would benefit from the same treatment once the version is clarified.

@rollandf rollandf closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants