Skip to content

fix: fix add/update log judgment — scope by user_name an… #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaralHsi merged 1 commit into from
Feb 25, 2026
Merged

fix: fix add/update log judgment — scope by user_name an… #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions src/memos/mem_scheduler/task_schedule_modules/handlers/add_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,37 @@ def log_add_messages(self, msg: ScheduleMessageItem):
original_item_id = None

if key and hasattr(mem_cube.text_mem, "graph_store"):
candidates = mem_cube.text_mem.graph_store.get_by_metadata(
[
{"field": "key", "op": "=", "value": key},
{
"field": "memory_type",
"op": "=",
"value": mem_item.metadata.memory_type,
},
]
)
try:
candidates = mem_cube.text_mem.graph_store.get_by_metadata(
[
{"field": "key", "op": "=", "value": key},
{
"field": "memory_type",
"op": "=",
"value": mem_item.metadata.memory_type,
},
],
user_name=msg.mem_cube_id,
)
except Exception as e:
logger.warning(
"get_by_metadata failed for memory_id=%s key=%s: %s",
memory_id,
key,
e,
)
candidates = []
# Exclude the current item itself — it was already persisted
# upstream by text_mem.add(), so it will always appear in the
# candidates and would cause every ADD to be mis-labelled as UPDATE.
candidates = [c for c in candidates if c != mem_item.id]
if candidates:
exists = True
original_item_id = candidates[0]
original_mem_item = mem_cube.text_mem.get(
memory_id=original_item_id, user_name=msg.mem_cube_id
)
original_content = original_mem_item.memory
original_content = original_mem_item.memory if original_mem_item else None

if exists:
prepared_update_items_with_original.append(
Expand Down