ci: keep local plugin release scripts trusted - #2199
Open
MLittleprince wants to merge 7 commits into
Open
Conversation
Collaborator
🤖 Open Code ReviewTarget: PR #2199 ✅ OpenCodeReview: No comments generated. Looks good to me. Generated by cloud-assistant via Open Code Review. |
Collaborator
✅ Automated Test Results: PASSEDAll tests passed (1/1 executed). memos_github_open_source/smoke: 1/1. Duration: 2s Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/scriptsfrom the workflow revision, even whengit_refpoints at older source codeWhy
Run 30809108630 checked out older release scripts through
git_ref, so a beta package-only release incorrectly called the Doc Agent.Run 30911517441 reached the stable/latest draft path and covered all 16 required sources, but generated more than the 12-item quality limit. The server correctly returned
needs_review=true; the workflow then hid the useful reason in a truncated error and retried the same deterministic rejection.This update keeps old source refs usable for package builds, makes quality failures inspectable, and guarantees a validation failure stops before npm publish, tag creation, or GitHub Release creation.
Validation
node --test .github/scripts/*.test.mjs(121/121 passed)node --check .github/scripts/draft-local-plugin-release-notes.mjsgit diff --checkNo npm publish, tag, GitHub Release, workflow dispatch, 106 webhook, docs PR, or deployment was run. The matching 106 compaction fix is in
MemTensor/website#2and must be merged/deployed before a real stable release validation.