fix(backend): quote hook commands for Windows shells - #153
Open
DevMello wants to merge 1 commit into
Open
Conversation
Hook commands used POSIX single quotes, which cmd.exe and PowerShell cannot execute, so installed hooks never ran on Windows. Use double quotes on win32 and keep the POSIX form elsewhere. Fixes MemTensor#149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install plugin wraps hook commands in POSIX single quotes. cmd.exe treats those as literal characters and PowerShell parses them as string expressions, so installed hooks never run on Windows and memory capture silently stops (#149).
Fix: double quotes on win32, POSIX form unchanged elsewhere, bare command names left unquoted. Verified on Windows 11 under cmd.exe; hook-command.test.ts now covers both platforms.
Fixes #149