feat(release): add signed manifest readiness model#17
Conversation
…t (PHASE 1+2) Per CEO_GO_VTOOLS_RELEASE_READINESS_FULL_CAMPAIGN_NO_RELEASE_01. Gold standard gaps fixed (demonstrable): - PHASE 1: Design packet completely absent. Added comprehensive RELEASE-READINESS-DESIGN.md covering all 9 required points exactly. - PHASE 2: No signed manifest / snapshot binding. Added load_and_verify_manifest() with all required bindings (snapshot file hash, repo commit, schema/verifier placeholders, claim_boundary, etc.). Fail-closed. - Demo signature using explicit TEST-ONLY HMAC (never for prod). Production Ed25519 + Founder key required. - Updated README with campaign status and pointer (no overclaims). - Hygiene (PHASE 0) already clean on this branch; design references evidence preservation. All work strictly inside token scope. No release, no keys, no claims elevation. No split brain — committed directly on codex/vtools-release-readiness-campaign. Codex: review the design and manifest code. Test with example vault + generated test manifest. See also: the verifier now accepts --manifest and --repo-commit.
…fest example for --manifest Per CEO_GO_VTOOLS_RELEASE_READINESS_FULL_CAMPAIGN_NO_RELEASE_01. - Hygiene removal complete on branch (9 items gone, clean tree). - Quarantine manifest evidence preserved externally (previous SHA 580EE041...); referenced in design. - Added example test manifest generation note for campaign validation. - No production claims or keys. Codex: use the --manifest path in future tests. Update schema/verifier hashes in real manifests.
Per CEO_GO_VTOOLS_RELEASE_READINESS_FULL_CAMPAIGN_NO_RELEASE_01 (same branch as Codex). Demonstrated gaps fixed: - PHASE 2/6: run-gates.sh did not actually execute the new manifest verifier with positive + negative cases (only allowlist). Added M-1/M-2 sub-gates that assert success on good fixture and fail-closed on tampered snapshot. - PHASE 4: Added release/BOOTSTRAP.md with offline steps, reproducibility notes, and explicit claim boundaries. - PHASE 5/1: Patched docs/release-readiness.md to contain explicit numbered 1-9 mapping matching the CEO order (was missing structured coverage). - PHASE 6: Created AUDITS/EVIDENCE/INTERNAL_SWARM_REPORT.md with formal P0/P1/P2 (PASS-WITH-NOTES). All changes: - Stay strictly inside token scope. - Add no real keys, no release/tag/publish. - Preserve fail-closed and honest limitations. - Include comments for Codex. Codex: review the new gates and BOOTSTRAP. The external prompt is in AUDITS/EVIDENCE/external_audit_prompt.txt — launch with gemini/deepseek/qwen. No deviation from mission observed in current tree; these are pure completeness/evidence gaps.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeef99f776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8a2404837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33f0071cdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Require --release-mode for profile=release-candidate, verify OpenSSL against already-read bytes, disable Git replacement refs on proof-critical calls, and fix G-18d3 to hit the real snapshot escape diagnostic under an absolute repo root. Refresh G-19 run-gates and release-material pins as a direct mechanical consequence. Token: CEO_GO_GROK_VTOOLS_PR17_4THREAD_PATCH_ONLY_01
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbb107049d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Authority
CEO_GO_VTOOLS_RELEASE_READINESS_FULL_CAMPAIGN_NO_RELEASE_01
Follow-on execution tokens:
CEO_GO_GROK_VTOOLS_PR17_4THREAD_PATCH_ONLY_01(applied on headfbb1070)CEO_GO_VTOOLS_PR17_GROK_FINAL_AUDIT_AND_BODY_REANCHOR_REVIEW_01(this body reanchor; no code change)B-01 authority provenance: campaign token was authorized in CEO/Founder conversation context. The repo cannot self-prove chat provenance; this PR classifies it as external CEO/Founder authority, not repo-internal evidence.
Scope
Draft release-readiness campaign only. This PR does not publish a release, tag, package, deploy, signature ceremony, signed release artifact, external attestation, SLSA provenance, CISO/NASA readiness claim, zero-debt claim, global clean-close claim, or public release readiness claim.
Current Head-Bound State
23b61fc188127e8787f687fd002dd4925155ad4cfbb107049d580500eb3c56a79c47bba14de7951914+1216 / -1114Verification Tools CIrun28985524857success on Ubuntu and Windows for headfbb107049d580500eb3c56a79c47bba14de79519[]/ total_count0Superseded heads (historical only)
33f0071cdcbb875357ca7ac61a331527cbed2dd2— prior head; Codex Review email findings on this SHA are historical and closed byfbb1070b8a24048372c6b96087cc1a6092f5cbf5bd9e22band earlier campaign heads — supersededAny PR narrative, Drive report, or Gmail that still binds "current head" to
33f0071is stale relative to GitHub metadata.What Changed
memoriaia/verify/verify-release-manifest.pyplus shell wrapperverify/verify-release-manifest.sh.release/fixtures/and a test public key for fixture validation.release/README.mdandrelease/BOOTSTRAP.mddescribing internal-snapshot-only manifest semantics and missing release-grade requirements.docs/release-readiness.mdwith explicit claim boundaries.release/BOOTSTRAP.md.--release-moderequires--expected-public-key-sha256from outside the manifest.VT_G19_EXEC_PROOFemission.repo_commitmust resolve as a commit object, not merely any 40-hex object.$PYinterpreter for the M-2 manifest tamper step.fbb1070(4-thread patch):profile: release-candidatefails closed unless--release-modeis set (gateG-18d0).verify_signature_bytes).--repo-root "$ROOT"and assertssnapshot path escapes repository.GIT_NO_REPLACE_OBJECTS=1andgit --no-replace-objects.Evidence On Current Head (
fbb1070)Remote CI run
28985524857onfbb107049d580500eb3c56a79c47bba14de79519:gates (ubuntu-latest): PASSgates (windows-latest): PASSWhitespace guard: PASS in both jobsRun verification gate suite: PASS in both jobsG-19 CI anti-theater (run-gates execution proof required): PASS in both jobs[]Local gates on the same head (pre-push):
Workflow Pins At Current Head (
fbb1070)Negative Evidence Included In Gates
--release-moderejects (G-18d0).repo_commitrejects; real commitrepo_commitis accepted when otherwise valid.Review Boundary
33f0071cdcbb875357ca7ac61a331527cbed2dd2(email notification) is historical.fbb1070and the corresponding GitHub threads are resolved with head-bound evidence.fbb1070may open new debt; that would be a new cycle, not residual33f0071debt.Explicit Boundaries
This PR supports at most a draft packet for CEO review after body/evidence reanchor. It does not establish:
Next Required Decision (CEO only)
Authorized maximum after this reanchor: CEO may evaluate whether to issue a separate ready/merge/postverify token.
Not authorized by this PR body: mark ready, merge, release, tag, sign production, publish package, deploy, or delete branch.
Suggested next token if CEO accepts the packet:
That token is not issued by this body update.