Fixed color selection for map sketching #4274

gabriel-bolbotina · 2025-12-22T14:01:54Z

Modified the components inside the MMSKetchesDrawer.

Below there is the fixed UI:

ScreenRecording_12-22-2025.16-00-28_1.MP4

Withalion

Now it's probably a good time to create component out of the solutions in MMSketchesDrawer.qml and MMFormPhotoSketchingPageDialog.qml.

github-actions · 2026-01-02T09:02:24Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 61741 dmg	Expires: 02/04/2026	#6174
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 53671 win64	Expires: 02/04/2026	#5367
Android Build	📬	Mergin Maps 748411 APK [armeabi-v7a]	Expires: 02/04/2026	#7484
Android Build	📬	Mergin Maps 748451 APK [arm64-v8a]	Expires: 02/04/2026	#7484
iOS Build	📬		Build number: 26.01.842511	#8425

Withalion

There is some additional work that needs to be done before we can proceed further

app/qml/components/MMPhotoColorPicker.qml

app/qml/map/MMSketchesDrawer.qml

app/qml/components/MMPhotoColorPicker.qml

app/qml/form/components/MMFormPhotoSketchingPageDialog.qml

app/qml/components/MMPhotoColorPicker.qml

github-actions · 2026-01-16T14:29:19Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📭	Build not yet complete or failed.
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 53971 win64	Expires: 16/04/2026	#5397
Android Build	📬	Mergin Maps 751451 APK [arm64-v8a]	Expires: 16/04/2026	#7514
Android Build	📬	Mergin Maps 751411 APK [armeabi-v7a]	Expires: 16/04/2026	#7514
iOS Build	📬		Build number: 26.01.845511	#8455

Withalion

Looks much nicer

Side note: I was able to scroll the colors without any issues on android, but it doesn't work at all on desktop.

app/mmstyle.h

app/qml/map/MMSketchesDrawer.qml

app/qml/components/MMColorPicker.qml

app/qml/components/MMColorButton.qml

Withalion

Great work!

app/qml/map/MMSketchesDrawer.qml

github-actions · 2026-01-20T07:26:10Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 62161 dmg	Expires: 20/04/2026	#6216
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 54091 win64	Expires: 20/04/2026	#5409
Android Build	📬	Mergin Maps 752651 APK [arm64-v8a]	Expires: 20/04/2026	#7526
Android Build	📬	Mergin Maps 752611 APK [armeabi-v7a]	Expires: 20/04/2026	#7526
iOS Build	📬		Build number: 26.01.846711	#8467

tomasMizera · 2026-01-21T20:19:43Z

app/qml/components/MMColorButton.qml

@@ -0,0 +1,30 @@
+import QtQuick


Missing licence header

Also in other files

tomasMizera · 2026-01-21T20:21:43Z

app/qml/components/MMColorButton.qml

@@ -0,0 +1,30 @@
+import QtQuick
+
+MMRoundButton {


Is there any reason to base this from MMRoundButton? It seems like these two have nothing in common. You are rewriting the whole component here.

I guess I was the one creating the initial Component and it made more sense in the previous version to modify MMRoundButton instead. As we are creating a new component here yeah it's good point to rebase the component.

tomasMizera · 2026-01-21T20:24:51Z

app/qml/components/MMColorButton.qml

+MMRoundButton {
+    id: root
+
+    required property color chosenColor


If the button is chosen or not is defined by the isSelected prop, right? In that case this is just a color, no matter if the button is selected or not.

Suggested change

required property color chosenColor

required property color buttonColor

tomasMizera · 2026-01-21T20:27:18Z

app/qml/components/MMColorButton.qml

+        width: __style.margin48
+        height: __style.margin48
+
+        color: root.isSelected ? __style.transparentColor : __style.lightGreenColor


The background color is lightGreen if the button is not selected? 🤔

Yes it creates this slightly visible halo around the button. Important for white and similar colors, which can blend with background.

tomasMizera · 2026-01-21T20:32:27Z

app/qml/form/components/MMFormPhotoSketchingPageDialog.qml

    MMComponents.MMListSpacer { implicitHeight: __style.margin20 }

-    ScrollView {
+    MMComponents.MMColorPicker{


The width is never defined

tomasMizera · 2026-01-21T20:36:37Z

app/qml/map/MMSketchesDrawer.qml

+        Layout.preferredHeight: scrollRow.height
+        Layout.preferredWidth: scrollRow.width


scrollRow is a nested id inside MMColorPicker. It should not be used outside of its file. Unless I am missing something, the width of the color picker should be set from outside, just like you set maximumWidth.

Modified map sketching so that the picked color is visible

7b8fd73

gabriel-bolbotina requested a review from Withalion December 22, 2025 14:01

gabriel-bolbotina linked an issue Dec 22, 2025 that may be closed by this pull request

Map sketching color buttons do not show which one is selected #4259

Open

Withalion requested changes Dec 23, 2025

View reviewed changes

Created reusable component for color picker

210b517

gabriel-bolbotina requested a review from Withalion January 2, 2026 09:56

Withalion reviewed Jan 9, 2026

View reviewed changes

Implemented code findings

a288041

gabriel-bolbotina requested a review from Withalion January 16, 2026 14:07

Withalion reviewed Jan 19, 2026

View reviewed changes

Implemented code findings

74c459a

gabriel-bolbotina requested a review from Withalion January 19, 2026 16:02

Withalion approved these changes Jan 19, 2026

View reviewed changes

Withalion reviewed Jan 19, 2026

View reviewed changes

app/qml/map/MMSketchesDrawer.qml Outdated Show resolved Hide resolved

app/qml/map/MMSketchesDrawer.qml Outdated Show resolved Hide resolved

Withalion requested a review from tomasMizera January 19, 2026 20:26

Fixed compiling error

95b19f6

tomasMizera requested changes Jan 21, 2026

View reviewed changes

	required property color chosenColor
	required property color buttonColor

		Layout.preferredHeight: scrollRow.height
		Layout.preferredWidth: scrollRow.width

Fixed color selection for map sketching #4274

Are you sure you want to change the base?

Fixed color selection for map sketching #4274

Conversation

gabriel-bolbotina commented Dec 22, 2025 • edited by Withalion Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 2, 2026

📦 Build Artifacts Ready

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2026

📦 Build Artifacts Ready

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026

📦 Build Artifacts Ready

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabriel-bolbotina commented Dec 22, 2025 •

edited by Withalion

Loading