-
Notifications
You must be signed in to change notification settings - Fork 75
Add more information for the SSL erros #4278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabriel-bolbotina
wants to merge
6
commits into
master
Choose a base branch
from
feature/add-more-info-ssl-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added flags for iOS build
📦 Build Artifacts Ready
|
Withalion
requested changes
Jan 9, 2026
📦 Build Artifacts Ready
|
Withalion
reviewed
Jan 19, 2026
Co-authored-by: Matej Bagar <matej.bagar@lutraconsulting.co.uk>
📦 Build Artifacts Ready
|
Withalion
approved these changes
Jan 19, 2026
tomasMizera
approved these changes
Jan 21, 2026
Collaborator
tomasMizera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Tip: We change network manager in some unit tests to mock server responses (see MerginApi::setNetworkManager). In that case you won't receive this signal as the manager object is different. It won't be an issue outside of unit tests though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video.mov
I tested it using docker nginx and an expired certificate