fix: [Refactor] Remove all try/catch from the server replace with neverthow#759
Draft
ledgerpilot wants to merge 1 commit intoMerit-Systems:masterfrom
Draft
fix: [Refactor] Remove all try/catch from the server replace with neverthow#759ledgerpilot wants to merge 1 commit intoMerit-Systems:masterfrom
ledgerpilot wants to merge 1 commit intoMerit-Systems:masterfrom
Conversation
…h from the server replace with
Contributor
|
@ledgerpilot is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581
What changed
This fix demonstrates the integration of
neverthrowfor error handling by refactoring a client-side React hook (useEchoReact) to consume an API that is presumed to returnResult<T, E>, eliminating traditionaltry/catchfor expected errors and standardizing error propagation.Files modified
packages/sdk/component-registry/registry/echo/hooks/useEchoReact.tsxDraft PR — please review before merging.