Fix/collapse bare tuple - #2
Merged
Merged
Conversation
Bad-arity unify now surfaces the upstream interpreter.rs message shape
("expected: (unify <atom> <pattern> <then> <else>), found: ...") instead of
a generic string. Upstream-PR candidate.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Represent variable aliases explicitly, reconcile class-wide values, retain unifier alias traces, and prove the repaired binding and substitution laws.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Courtesy of Fable 5, Opus 4.8, Codex 5.5 and 5.6.
What this changes
Repairs equality-class binding reconciliation so a variable's equality class survives
matching and instantiation:
(g $a $a $b)against(= (g $p1 $p2 $p2) (f $p1 $p2))now returns
(f $a $a)to match Hyperon, not(f $a $b). A preliminary commit alignsthe malformed
unifyerror atom with the interpreter's message shape.The checklist (all verified locally, once the fix above is folded in)
lake buildsucceeds: the kernel, theLeaTTabinary, and the Mathlib metatheory.sorry,admit,native_decide,partial, orunsafeinMettaHyperonFull/.make oracle).make regression).Proofs/, and the executable kernel stays Mathlib free.Evidence, each run just now on the branch: