Skip to content

feat: annotated string resolver#100

Merged
MessiasLima merged 3 commits into
mainfrom
80-implement-annotatedstringresolver
Jul 6, 2026
Merged

feat: annotated string resolver#100
MessiasLima merged 3 commits into
mainfrom
80-implement-annotatedstringresolver

Conversation

@MessiasLima

Copy link
Copy Markdown
Owner

Summary

Describe what this pull request changes and why.

Checklist

  • Tests were added or updated when needed
  • Documentation was updated when needed

@MessiasLima MessiasLima linked an issue Jul 6, 2026 that may be closed by this pull request
4 tasks
@github-project-automation github-project-automation Bot moved this to Ready in Some Jul 6, 2026
@MessiasLima MessiasLima changed the title feat: annotated string feat: annotated string resolver Jul 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for resolving Jetpack Compose's AnnotatedString type in the Android module by introducing AnnotatedStringResolver and registering it in AndroidResolverProvider. The feedback suggests declaring the Compose dependency as compileOnly and conditionally loading the resolver to prevent bloating the dependency graph and avoiding NoClassDefFoundError for non-Compose users. Additionally, it is recommended to optimize string generation using CharArray to avoid unnecessary allocations, and to remove the RobolectricTestRunner from the resolver's unit tests since AnnotatedString does not depend on Android framework APIs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread android/build.gradle.kts
@MessiasLima MessiasLima merged commit 8b5140e into main Jul 6, 2026
1 check passed
@MessiasLima MessiasLima deleted the 80-implement-annotatedstringresolver branch July 6, 2026 17:09
@github-project-automation github-project-automation Bot moved this from Ready to Done in Some Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement AnnotatedStringResolver

1 participant