Skip to content

feat: Compose color provider#101

Merged
MessiasLima merged 2 commits into
mainfrom
81-implement-compose-graphics-resolvers-color-colorstrategy-solidcolor
Jul 6, 2026
Merged

feat: Compose color provider#101
MessiasLima merged 2 commits into
mainfrom
81-implement-compose-graphics-resolvers-color-colorstrategy-solidcolor

Conversation

@MessiasLima

Copy link
Copy Markdown
Owner

Summary

Describe what this pull request changes and why.

Checklist

  • Tests were added or updated when needed
  • Documentation was updated when needed

@MessiasLima MessiasLima linked an issue Jul 6, 2026 that may be closed by this pull request
6 tasks
@github-project-automation github-project-automation Bot moved this to Ready in Some Jul 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for resolving Jetpack Compose Color values in the some-android module. It adds a new ColorResolver and a configurable ColorStrategy supporting random ARGB, random HSL, and fixed palette strategies, along with corresponding tests and documentation. The review feedback highlights a bug where the RandomHsl strategy incorrectly uses Color.hsv instead of Color.hsl, and suggests strengthening the associated unit tests to assert the correct HSL-converted values rather than just verifying a non-null result.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@MessiasLima MessiasLima merged commit 1174e29 into main Jul 6, 2026
1 check passed
@MessiasLima MessiasLima deleted the 81-implement-compose-graphics-resolvers-color-colorstrategy-solidcolor branch July 6, 2026 17:35
@github-project-automation github-project-automation Bot moved this from Ready to Done in Some Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement Compose graphics resolvers (Color, ColorStrategy, SolidColor)

1 participant