Skip to content

feat: pair userhandle and color resolvers#99

Merged
MessiasLima merged 3 commits into
mainfrom
79-implement-pair-userhandle-and-color-resolvers
Jul 6, 2026
Merged

feat: pair userhandle and color resolvers#99
MessiasLima merged 3 commits into
mainfrom
79-implement-pair-userhandle-and-color-resolvers

Conversation

@MessiasLima

Copy link
Copy Markdown
Owner

Summary

Describe what this pull request changes and why.

Checklist

  • Tests were added or updated when needed
  • Documentation was updated when needed

@MessiasLima MessiasLima linked an issue Jul 6, 2026 that may be closed by this pull request
5 tasks
@github-project-automation github-project-automation Bot moved this to Ready in Some Jul 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new Android-specific resolvers (ColorResolver, PairResolver, and UserHandleResolver) along with unit tests and documentation updates that bump the minSdk to 26. Feedback on these changes highlights that the new resolvers are not registered in AndroidResolverProvider, rendering them inactive. Additionally, ColorResolver incorrectly passes out-of-bounds float values to Color.valueOf, and UserHandleResolver can generate invalid system or negative UIDs. To avoid a breaking change, it is recommended to keep the minSdk at 24 and conditionally register API 26+ resolvers at runtime, while also strengthening the unit tests to assert valid value ranges rather than just types.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/android/index.md
Comment thread docs/getting-started.md
@MessiasLima MessiasLima merged commit 7e36015 into main Jul 6, 2026
1 check passed
@MessiasLima MessiasLima deleted the 79-implement-pair-userhandle-and-color-resolvers branch July 6, 2026 16:48
@github-project-automation github-project-automation Bot moved this from Ready to Done in Some Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement Pair, UserHandle, and Color resolvers

1 participant