Open
Conversation
github-actions
bot
added
the
cla-required
Sam Clarke-Green (t00sa)
requested a review
from Andrew Coughtrie (andrewcoughtrie)
github-actions
bot
added
cla-signed
Andrew Coughtrie (andrewcoughtrie)
requested changes
Mar 26, 2026
Collaborator
Andrew Coughtrie (andrewcoughtrie)
left a comment
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
I've tested that this works correctly allowing the correct length of calliper names when built and installed.
Just a couple of small changes to make the error message more meaning full to users.
src/c++/hashtable.cpp
Outdated
| if (region_name.length() + num_extra_bytes > new_chars.size()) { | ||
| error_handler("Internal error: character buffer exhausted.", EXIT_FAILURE); | ||
| std::stringstream message; | ||
| message << "Internal error: region name too long (" |
Collaborator
There was a problem hiding this comment.
Just to make this obvious it comes from Vernier, I intend to refactor logging to be better but we might as well make this message obvious now.
Suggested change
| message << "Internal error: region name too long (" | |
| message << "Vernier internal error: region name too long (" |
|
|
||
| EXPECT_EXIT(meto::vernier.start(label), testing::ExitedWithCode(1), | ||
| "Internal error: character buffer exhausted."); | ||
| HasSubstr("Internal error: region name too long")); |
Collaborator
There was a problem hiding this comment.
Suggested change
| HasSubstr("Internal error: region name too long")); | |
| HasSubstr("Vernier internal error: region name too long")); |
Sam Clarke-Green (t00sa)
requested a review
from Andrew Coughtrie (andrewcoughtrie)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug which prevented the string buffer CMake parameter from setting the
PROF_STRING_BUFFER_LENGTHpre-processor macro correctly. Also improve the error message the results if the region name length is too long.Linked issues
Closes #226
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: