Main to Stable 2026.03.1 by jennyhickson · Pull Request #315 · MetOffice/lfric_apps

jennyhickson · 2026-03-03T15:57:49Z

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo

Code Quality Checklist

I have performed a self-review of my own code
My code follows the project's style guidelines
Comments have been included that aid understanding and enhance the readability of the code
My changes generate no new warnings
All automated checks in the CI pipeline have completed successfully

Testing

I have tested this change locally, using the LFRic Apps rose-stem suite
If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

I have reviewed my changes for potential security issues
Sensitive data is properly handled (if applicable)
Authentication and authorisation are properly implemented (if applicable)

Performance Impact

Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

I understand this area of code and the changes being added
The proposed changes correspond to the pull request description
Documentation is sufficient (do documentation papers need updating)
Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

All dependencies have been resolved
Related Issues have been properly linked and addressed
CLA compliance has been confirmed
Code quality standards have been met
Tests are adequate and have passed
Documentation is complete and accurate
Security considerations have been addressed
Performance impact is acceptable

Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com>

Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>

Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com> Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>

…to true (#71)

Co-authored-by: mike-hobson <26921912+mike-hobson@users.noreply.github.com>

Co-authored-by: Ed Hone <68642690+EdHone@users.noreply.github.com>

This workflow automatically sets up the reviewers and the review state of the PR.

Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com> Commit ticket, linked to Lfric_core PR#201

Committed by: cameronbateman-mo <cameron.bateman@metoffice.gov.uk>

…om CELL_COLUMN to DOMAIN kernel (#99) Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> Co-authored-by: Erica Neininger <erica.neininger@metoffice.gov.uk>

Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com>

Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>

Co-authored-by: Harry Shepherd <17930806+harry-shepherd@users.noreply.github.com> (Merged main into branch)

This stand alone change is part of a change set targeting performance management and optimisation, derived from trac ticket 1002 This change set targets the configuration of tests, MPI management, I/O server interfacing and output file setup.

Co-authored-by: Cameron Bateman <cameron.bateman@metoffice.gov.uk>

Co-authored-by: Alistair Pirrie <187289694+mo-alistairp@users.noreply.github.com>

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com>

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Co-authored-by: Iva Kavcic <TeranIvy@users.noreply.github.com> Co-authored-by: Mike Hobson <26921912+mike-hobson@users.noreply.github.com> Co-authored-by: mo-marqh <87382490+mo-marqh@users.noreply.github.com>

Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com> Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com>

…ergences (#281) Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>

) Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com> Co-authored-by: mo-lucy-gordon <lucy.gordon@metoffice.gov.uk> Co-authored-by: mo-lucy-gordon <120176477+mo-lucy-gordon@users.noreply.github.com>

Co-authored-by: EdHone <edward.hone@metoffice.gov.uk>

Co-authored-by: Iva Kavcic <TeranIvy@users.noreply.github.com>

…ization scripts (#302)

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>

github-actions · 2026-03-03T15:58:14Z

⚠️ Hello @jennyhickson!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

jennyhickson and others added 30 commits December 11, 2025 10:03

Stable to Main, vn3.0 (#38)

7a9ae22

Docs deploy only triggers on upstream (#39)

0b1e210

fix local build script (#43)

9163b6f

Remove user contact question from issue template (#63)

6228015

Signed CLA (#78)

e1e12b8

Check config name (#67)

bcc8b6e

Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com>

Add Harry Shepherd to CONTRIBUTORS.md (#96)

ce7a652

Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>

Reformat pull request template (#109)

1deda77

update symlink (#102)

b2ad7ff

Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com> Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>

Hotfix to rose-stem suite (#131)

043b2b2

Fixing adjoint failures with transport log_space config variable set …

144de38

…to true (#71)

Add workflow to block direct merges to the stable branch (#140)

afdf37d

cla signed (#147)

473dec8

Fix coupled model with 32bit compilation (#143)

03e7d4a

Co-authored-by: mike-hobson <26921912+mike-hobson@users.noreply.github.com>

buffer_size_factor: fix broken XIOS attribute name in XML configs (#144)

005bf21

Co-authored-by: Ed Hone <68642690+EdHone@users.noreply.github.com>

Sign contributors (#155)

1cb2f7c

Add project workflow (#117)

e55b974

This workflow automatically sets up the reviewers and the review state of the PR.

Timing Mod wrapper rewrite (#80)

0e97c8e

Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com> Commit ticket, linked to Lfric_core PR#201

Update UKCA initialisation for dust only to include segment size (#83)

38daf6d

Committed by: cameronbateman-mo <cameron.bateman@metoffice.gov.uk>

Update gitignore (#75)

8fcccda

Gregory-Rowntree convection - PSyclone optimisation and conversion fr…

41e3776

…om CELL_COLUMN to DOMAIN kernel (#99) Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> Co-authored-by: Erica Neininger <erica.neininger@metoffice.gov.uk>

Remove use of deprecated XIOS context API (#183)

47380ae

Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com>

Stochastic Physics CPU and GPU Optimizations - NGARCH (#65)

7f9055c

update jedi owners (#173)

0a153e9

Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>

Introducing cache for adjoint lookup tables (#72)

9f301ea

Co-authored-by: Harry Shepherd <17930806+harry-shepherd@users.noreply.github.com> (Merged main into branch)

Performance test config (#82)

0fb9b1a

This stand alone change is part of a change set targeting performance management and optimisation, derived from trac ticket 1002 This change set targets the configuration of tests, MPI management, I/O server interfacing and output file setup.

Bug in AOD diagnostics (#94)

1557a97

Co-authored-by: Cameron Bateman <cameron.bateman@metoffice.gov.uk>

Removing populate_graph_lfricinputs.cylc (#54)

4fef669

Co-authored-by: Alistair Pirrie <187289694+mo-alistairp@users.noreply.github.com>

Update gitattributes diff to fortran-free-form (#190)

f71849c

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

#123 Align adjoint_tests to linear_model

c118c3d

harry-shepherd and others added 21 commits February 19, 2026 15:24

Update to use the new GC6 PrgEnv module (#254)

c1a3b09

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Fix email link format for TCD Team contact in PR template (#274)

23f8a8e

Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com>

Allow different meshes to have different maximum halo depths (#174)

3567ba5

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Plumbing in adjoint lookup table caches to interface (#271)

b9baf6a

Linear and adjoint boundary layer physics (#182)

f9c38b5

Co-authored-by: Iva Kavcic <TeranIvy@users.noreply.github.com> Co-authored-by: Mike Hobson <26921912+mike-hobson@users.noreply.github.com> Co-authored-by: mo-marqh <87382490+mo-marqh@users.noreply.github.com>

Solver improvements (#177)

325bf94

Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com> Co-authored-by: Ricky Wong <141156427+mo-rickywong@users.noreply.github.com>

Extend length of nrun/crun test as previous test failed to expose div…

959ec7b

…ergences (#281) Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Update templates (#284)

193fac4

Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>

Additional PC2 optimisations for NG-ARCH (#53)

0669da2

Co-authored-by: EdHone <edward.hone@metoffice.gov.uk>

fix paths to data, missed from #182 (#295)

efbd62d

3panel test 1 thread (#293)

e859e60

Remove short-circuit evaluation from IF statement (#267)

40019d2

Co-authored-by: Iva Kavcic <TeranIvy@users.noreply.github.com>

Big data sym links (#296)

f8c2d69

Update NCI GADI rose-stem suite config environment settings and optim…

e590c45

…ization scripts (#302)

Uoe symlinks (#303)

dd6d054

Update JEDI and lfric2lfric codeowners (#283)

a4c0ba9

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

Move failing tests (#305)

1f989d3

Fix JEDI_LFRic forecast_pseudo test config (#300)

2843ed2

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>

Relax test tolerance of atlt_vert_w3_reconstruct_alg (#309)

350ec76

lfric_apps vn3.1 release (#307)

1b715f6

Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>

jennyhickson requested a review from maggiehendry as a code owner March 3, 2026 15:57

jennyhickson requested review from james-bruten-mo and removed request for maggiehendry March 3, 2026 15:58

github-actions bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Mar 3, 2026

github-actions bot assigned jennyhickson Mar 3, 2026

james-bruten-mo approved these changes Mar 3, 2026

View reviewed changes

james-bruten-mo merged commit 3d53b0c into stable Mar 3, 2026
15 of 17 checks passed

james-bruten-mo added this to the Spring 2026 milestone Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main to Stable 2026.03.1#315

Main to Stable 2026.03.1#315
james-bruten-mo merged 97 commits intostablefrom
main

jennyhickson commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

jennyhickson commented Mar 3, 2026

PR Summary

Code Quality Checklist

Testing

trac.log

Security Considerations

Performance Impact

AI Assistance and Attribution

Documentation

PSyclone Approval

Sci/Tech Review

Code Review

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants