Update App calls to partition type api#324
Draft
mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
Draft
Update App calls to partition type api#324mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
Conversation
29 tasks
ukmo-juan-castillo
approved these changes
Mar 5, 2026
Contributor
ukmo-juan-castillo
left a comment
There was a problem hiding this comment.
Everything in order. I checked that indeed lfric2lfric does not perform any checking in the multigrid meshes as expected.
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @ukmo-juan-castillo
Code Reviewer: @mike-hobson
Update Lfric-Apps repo to work with changes to partition type constructor. Allows applications to disable Gungho Multigrid checks where not applicable.
Linked PRs
Blocking PRs
Code Quality Checklist
Testing
Rose Stem testing shows no change to KGOS, Local test with Lfric2Lfric mpi ranks set to 6 confirms that Lfric2Lfric
tasks will now run without aborting on Multigrid mapping checks. Which is the purpose of this PR. No new tasks with multiple mpis have been added as these would not produce correct output.
trac.log
Test Suite Results - lfric_apps - lfric2lfricNoMaps/run12
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review