Skip to content

Update App calls to partition type api#324

Draft
mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
mo-rickywong:lfric2lfric_IgnoreMaps
Draft

Update App calls to partition type api#324
mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
mo-rickywong:lfric2lfric_IgnoreMaps

Conversation

@mo-rickywong
Copy link
Contributor

@mo-rickywong mo-rickywong commented Mar 4, 2026

PR Summary

Sci/Tech Reviewer: @ukmo-juan-castillo
Code Reviewer: @mike-hobson

Update Lfric-Apps repo to work with changes to partition type constructor. Allows applications to disable Gungho Multigrid checks where not applicable.

Linked PRs

Blocking PRs

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

Rose Stem testing shows no change to KGOS, Local test with Lfric2Lfric mpi ranks set to 6 confirms that Lfric2Lfric
tasks will now run without aborting on Multigrid mapping checks. Which is the purpose of this PR. No new tasks with multiple mpis have been added as these would not produce correct output.

trac.log

Test Suite Results - lfric_apps - lfric2lfricNoMaps/run12

Suite Information

Item Value
Suite Name lfric2lfricNoMaps/run12
Suite User ricky.wong
Workflow Start 2026-03-04T12:16:54
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@69aaf4d True
lfric_apps MetOffice/lfric_apps@lfric2lfricNoMaps False
lfric_core MetOffice/lfric_core@EnforcePartitionRestrictions False
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

✅ succeeded tasks - 1164

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-rickywong mo-rickywong changed the title Commit branch from fork Update partition type api Mar 4, 2026
@mo-rickywong mo-rickywong changed the title Update partition type api Update App calls to partition type api Mar 4, 2026
Copy link
Contributor

@ukmo-juan-castillo ukmo-juan-castillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in order. I checked that indeed lfric2lfric does not perform any checking in the multigrid meshes as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants