Turn on bl_segment by default for lfric_atm jobs#382
Open
MetBenjaminWent wants to merge 4 commits intoMetOffice:mainfrom
Open
Turn on bl_segment by default for lfric_atm jobs#382MetBenjaminWent wants to merge 4 commits intoMetOffice:mainfrom
MetBenjaminWent wants to merge 4 commits intoMetOffice:mainfrom
Conversation
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn on bl_segment by default for lfric_atm jobs by updating relevent versions.py
Blocking which is being enabled with changes to the boundary layer, see #106, are improving the use of the segmentaion blocking variable bl_segment, which is present in the source.
Testing has indicated a minor boost at 1T, and a good boost at higher thread counts.
This assists with cache blocking in the routines.
This ticket should follow changes in #325, as it contains the most uses of the variable.
PR Summary
Sci/Tech Reviewer: @christophermaynard
Code Reviewer:
Umbrella issue: #106
Closes #327
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - bl_seg_size_versions/run3
Suite Information
Task Information
❌ failed tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review