-
Notifications
You must be signed in to change notification settings - Fork 56
New function space options for coordinate fields #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Thomas Bendall (tommbendall)
wants to merge
23
commits into
MetOffice:main
Choose a base branch
from
tommbendall:TBendall/CoordSpace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
27d4572
Implement options for coordinate space
tommbendall 5b5b336
first attempt at upgrade macro
tommbendall 42ebf5d
roll out new namelist options to nml files and unit-tests
tommbendall 003f721
fix upgrade macro
tommbendall 88ab8d5
lbc_demo app doesn't get pick up by upgrade macro so manually add new
tommbendall d9f1275
hopefully fix upgrade macro
tommbendall 6626374
avoid issues with Wtheta coordinate space on planar meshes
tommbendall cb53673
sign contributors
tommbendall 1608e7b
remove Wchi metadata from kernels
tommbendall ba7b575
do not evenly space Wtheta DoFs
tommbendall 65e26c7
remove myself from contributors
tommbendall 4c24461
implement continuous height kernel, and rename existing height kernel
tommbendall a545d03
fix test
tommbendall 24bba86
remove unused variables
tommbendall d7c34f3
Merge branch 'TBendall/vn3.0_height_continuous' into TBendall/CoordSpace
tommbendall 6afc9ca
treat height_wtheta with discontinuous kernel
tommbendall f7b754a
Merge branch 'TBendall/HeightContinuous' into TBendall/CoordSpace
tommbendall 0bba602
Main to Stable 2026.03.1 (#297)
james-bruten-mo 25b1083
Merge pull request #4 from MetOffice/stable
tommbendall 4c1deff
Merge remote-tracking branch 'origin/stable' into TBendall/HeightCont…
tommbendall cddbfeb
Merge branch 'TBendall/HeightContinuous' into TBendall/CoordSpace
tommbendall a7dc2a2
update upgrade macro
tommbendall 1f48550
rename coord_order_multigrid to coord_order_nonprime
tommbendall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file looks to have had the upgrade macro applied before review, so these changes should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in this file, I have just rewritten some of the metadata to make it clearer. I've double-checked and I haven't applied the upgrade macro to this branch!