Enable interpolation of time-varying input data with temporal controller#311
Open
EdHone wants to merge 9 commits intoMetOffice:mainfrom
Open
Enable interpolation of time-varying input data with temporal controller#311EdHone wants to merge 9 commits intoMetOffice:mainfrom
EdHone wants to merge 9 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @mo-lucy-gordon
Part of the work in #243.
The previous devlopments on the temporal controller object in #230 enable use to always have the correct data for the model time whilst maintaining the performance benefits and efficiency of the temporal controller. This PR implements basic linear interpolation of the input data at a user-specified time frequency. The changes include:
lfric_xios_temporal_modto enable the interpolationPlot showing data validity of field read in using temporal controller and interpolated with a user-defined frequency
closes #242
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric_core-242-temporal-interpolation/run4
Suite Information
Task Information
✅ succeeded tasks - 389
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review