Skip to content

Enable interpolation of time-varying input data with temporal controller#311

Open
EdHone wants to merge 9 commits intoMetOffice:mainfrom
EdHone:242-temporal-interpolation
Open

Enable interpolation of time-varying input data with temporal controller#311
EdHone wants to merge 9 commits intoMetOffice:mainfrom
EdHone:242-temporal-interpolation

Conversation

@EdHone
Copy link
Contributor

@EdHone EdHone commented Mar 16, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @mo-lucy-gordon

Part of the work in #243.
The previous devlopments on the temporal controller object in #230 enable use to always have the correct data for the model time whilst maintaining the performance benefits and efficiency of the temporal controller. This PR implements basic linear interpolation of the input data at a user-specified time frequency. The changes include:

  • developments to lfric_xios_temporal_mod to enable the interpolation
  • a new mechanism for parsing user-specified time information using enums (and a unit test)
  • two new integration tests which test the interpolation mechanism
LfricXiosFullInterpTest

Plot showing data validity of field read in using temporal controller and interpolated with a user-defined frequency

closes #242

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - lfric_core-242-temporal-interpolation/run4

Suite Information

Item Value
Suite Name lfric_core-242-temporal-interpolation/run4
Suite User edward.hone
Workflow Start 2026-03-16T14:02:06
Groups Run developer
Dependency Reference Main Like
lfric_core EdHone/lfric_core@242-temporal-interpolation False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 389

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@EdHone EdHone marked this pull request as ready for review March 16, 2026 14:27
@EdHone EdHone requested a review from a team as a code owner March 16, 2026 14:27
@EdHone EdHone requested review from mo-lucy-gordon and removed request for a team March 16, 2026 14:27
@james-bruten-mo james-bruten-mo removed the request for review from mo-lucy-gordon March 17, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time interpolation of input data with XIOS temporal type

2 participants