Script to generate CMIP7 future scenario solar forcing for GA9 spectral files#16
Script to generate CMIP7 future scenario solar forcing for GA9 spectral files#16James Manners (mo-jmanners) wants to merge 4 commits intoMetOffice:mainfrom
Conversation
…cript. Small bug-fixes in make_block_17 and nctools.
UV add-on from mainUV
Merge pull request #16 from nichollsh/mainUV
|
R Sharp (@r-sharp) (assuming this is what is meant by 'Please alert the code reviewer via a tag when you have approved the SR') Science review of this code is complete. No issues identified. |
martinbandrews
left a comment
There was a problem hiding this comment.
R Sharp (@r-sharp) (assuming this is what is meant by 'Please alert the code reviewer via a tag when you have approved the SR')
Science review of this code is complete. No issues identified.
(Above is a repeat of comment made in #16 as I'm learning how this github thing works and am trying to avoid making a hash of things!)
I have not approved as I guess Roddy needs to do the code review before pull/16 can be approved?
martinbandrews
left a comment
There was a problem hiding this comment.
The changes to the script includes the retrieval of files containing future CMIP7 solar variability and the production of spectral files suitable for the UM. The spectral files include both the historical dataset and the future dataset as a seamless timeseries.
The solar variability (TSI and SSI) data in the output spectral files reflect the original input dataset.
PR Summary
Sci/Tech Reviewer: martinbandrews
Code Reviewer: R Sharp (@r-sharp)
The run_cmip7 example script has been updated. The future solar spectral forcing is added on to the spectral var files following the end of the historical data (December 2023). The files this script creates are being added to the socrates-spectral repository under MetOffice/socrates-spectral/issues/5.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
No shared files have been modified.
Socrates quick_tests
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review