Skip to content

Script to generate CMIP7 future scenario solar forcing for GA9 spectral files#16

Open
James Manners (mo-jmanners) wants to merge 4 commits intoMetOffice:mainfrom
mo-jmanners:15_cmip7_future_solar
Open

Script to generate CMIP7 future scenario solar forcing for GA9 spectral files#16
James Manners (mo-jmanners) wants to merge 4 commits intoMetOffice:mainfrom
mo-jmanners:15_cmip7_future_solar

Conversation

@mo-jmanners
Copy link
Copy Markdown
Member

@mo-jmanners James Manners (mo-jmanners) commented Jan 30, 2026

PR Summary

Sci/Tech Reviewer: martinbandrews
Code Reviewer: R Sharp (@r-sharp)

The run_cmip7 example script has been updated. The future solar spectral forcing is added on to the spectral var files following the end of the historical data (December 2023). The files this script creates are being added to the socrates-spectral repository under MetOffice/socrates-spectral/issues/5.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

No shared files have been modified.

Socrates quick_tests

Testing code compiled in /home/users/james.manners/git/socrates_admin/bin
---
Testing simple calls to the runes interface:
Matched gfortran output
OK
---
Testing the runes_nc driver using LFRic diagnostic input:
Matched SW output
Matched LW output
OK
---
Testing raw_input to convert column data into input files:
OK
---
Testing Cl_run_cdl for ICRCCM case 27 (LW) on AER profiles:
OK
---
Testing Cl_run_cdf on multiple profiles:
OK
---
Test Cl_run_cdf for CIRC case 6
(HadGEM, GA7, SES and 300/260 band spectral files):
OK
---
Testing pseudo-spherical geometry code:
Calculating zenith angles:  75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
OK
---
Testing photolysis and non-LTE code:
Mapping sub-bands to channels.
Matched gfortran output
OK
---
Test McICA code (create mcica_data file and run on CRM profile):
OK
---
Testing creation of aerosol properties for a spectral file:
Running scatter_90...
Running scatter_average_90...
Running prep_spec...
Matched gfortran12 output
OK
---
Testing generating and running with prescribed optical properties:
Running raw_input...
Running Cscatter... please wait...
Running Cscatter... please wait...
Running Cscatter_average...
Running Cscatter_average...
Running prep_opt_profile...
Running Cl_run_cdl...
All done.
OK
---
Testing Crun_mono to calculate radiances:
Matched ref output
OK
---
Testing Ccorr_k to generate correlated-k coefficients:
Matched gfortran12 output
OK
---
Testing flexchem chemistry:
Matched KGO output
OK
---
Testing CDL scripts:
OK
---
All passed.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-jmanners James Manners (mo-jmanners) added bug Something isn't working enhancement New feature or request Linked Spectral This PR is linked to a MetOffice/socrates-spectral PR labels Jan 30, 2026
James Manners (mo-jmanners) added a commit to mo-jmanners/socrates that referenced this pull request Feb 24, 2026
Harrison Nicholls (nichollsh) referenced this pull request in FormingWorlds/SOCRATES Mar 19, 2026
Harrison Nicholls (nichollsh) referenced this pull request in FormingWorlds/SOCRATES Mar 19, 2026
Merge pull request #16 from nichollsh/mainUV
@martinbandrews
Copy link
Copy Markdown

R Sharp (@r-sharp) (assuming this is what is meant by 'Please alert the code reviewer via a tag when you have approved the SR')

Science review of this code is complete. No issues identified.

Copy link
Copy Markdown

@martinbandrews martinbandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R Sharp (@r-sharp) (assuming this is what is meant by 'Please alert the code reviewer via a tag when you have approved the SR')

Science review of this code is complete. No issues identified.

(Above is a repeat of comment made in #16 as I'm learning how this github thing works and am trying to avoid making a hash of things!)

I have not approved as I guess Roddy needs to do the code review before pull/16 can be approved?

@mo-jmanners James Manners (mo-jmanners) removed the bug Something isn't working label Apr 28, 2026
Copy link
Copy Markdown

@martinbandrews martinbandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the script includes the retrieval of files containing future CMIP7 solar variability and the production of spectral files suitable for the UM. The spectral files include both the historical dataset and the future dataset as a seamless timeseries.

The solar variability (TSI and SSI) data in the output spectral files reflect the original input dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Linked Spectral This PR is linked to a MetOffice/socrates-spectral PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMIP7 future scenario solar forcing for GA9 spectral files

4 participants