feat: Add catmaid spatially indexed skeletons#122
Draft
afonsobspinto wants to merge 262 commits intomasterfrom
Draft
feat: Add catmaid spatially indexed skeletons#122afonsobspinto wants to merge 262 commits intomasterfrom
afonsobspinto wants to merge 262 commits intomasterfrom
Conversation
…iltered vertex/index buffer per chunk and draw once per chunk,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
afonsobspinto
changed the title
…pand from skeleton tab
feat: Change skeleton viewer to use virtual list
will need to update the logic after this, but this moves to the version of the state where the user controlled value is the only thing stored in the state, and everything else needed for the computation is derived from this single control this will require updates in segmentation/index.ts further and then in skeleton/frontend.ts as some of the old things there won't be used
the old was adding custom css and behaviour but we can rely on the base instead for simplicity
on simplifing the render scale widget, I believe there is a good chunk of dead code. I don't think we need this as it should be handled separately.
the spatially indexed skeleton layer was previously requesting a redraw on many different watchables changing, but these are already covered in the registerRedrawWhenSegmentationDisplayState3DChanged There are a few new ones, but left a TODO about that For visibility, I don't see the use of it and it would need to account for the hidden alpha also to be correct, so removed
well intended, but because hidden + visible its easier to just read the code. + we clear some keys, not just skip rendering so it is misleading
fix: correct hidden alpha handling
feat: update state representation of seg layer for skeletons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression_test.zip