feat: improve overlay layer rendering#148
Draft
seankmartin wants to merge 9 commits intofeature/edit-modefrom
Draft
feat: improve overlay layer rendering#148seankmartin wants to merge 9 commits intofeature/edit-modefrom
seankmartin wants to merge 9 commits intofeature/edit-modefrom
Conversation
also reuse float array for color
previously was used to avoid double rendering with visible segments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, no major changes, just a little bit clearer in shader binding and then order. Also adds some debug flags which add a little bit of complexity, but I think are worth overall.
Next step will be looking into in detail the IDs that are given to the browse pass and how those are updated.