Skip to content

fix: Forces https scheme on export url #525

Merged
afonsobspinto merged 2 commits intodevelopfrom
feature/SCKAN-447
Oct 22, 2025
Merged

fix: Forces https scheme on export url #525
afonsobspinto merged 2 commits intodevelopfrom
feature/SCKAN-447

Conversation

@afonsobspinto
Copy link
Copy Markdown
Member

@afonsobspinto afonsobspinto requested a review from Copilot October 22, 2025 19:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR forces HTTPS scheme for export URLs by hardcoding the protocol in the nginx configuration and removing the scheme parameter from the export workflow. The changes ensure that all export URLs use HTTPS regardless of the incoming request protocol.

Key Changes:

  • Hardcoded HTTPS in nginx proxy configuration by replacing $scheme variable with literal https
  • Removed scheme parameter from export workflow invocation
  • Added logger service initialization in ingestion process

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
applications/composer/nginx.conf Changed X-Forwarded-Proto header from dynamic $scheme to hardcoded https
applications/composer/backend/composer/views.py Removed scheme parameter from run_export_workflow call
applications/composer/backend/composer/services/cs_ingestion/cs_ingestion_services.py Added logger service initialization at the start of ingest_statements function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@afonsobspinto afonsobspinto merged commit d2e3eca into develop Oct 22, 2025
1 check passed
@ddelpiano ddelpiano deleted the feature/SCKAN-447 branch November 14, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants