Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / core Public

Notifications You must be signed in to change notification settings
Fork 274
Star 393

Code
Issues 296
Pull requests 245
Actions
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security and quality
Insights

feat(keyring-controller): add `withController` for atomic operations over multiple keyrings#8416

Open

ccharly wants to merge 18 commits intomainMetaMask/core:mainfrom

cc/feat/with-keyringsMetaMask/core:cc/feat/with-keyringsCopy head branch name to clipboard

Conversation Commits18 (18)Checks Files changed

Open

feat(keyring-controller): add `withController` for atomic operations over multiple keyrings#8416
ccharly wants to merge 18 commits intomainfrom
cc/feat/with-keyrings

Commits

Commits on Apr 13, 2026

feat(keyring-controller): add withController for atomic operations over multiple keyrings
ccharly
committed
chore: changelog
ccharly
committed
feat: expose withController as an action
ccharly
committed
test: add test for action
ccharly
committed
chore: lint
ccharly
committed
refactor: better comments + add KeyringEntry type
ccharly
committed
chore: docs
ccharly
committed
chore: lint
ccharly
committed
refactor: use KeyringEntry in RestrictedController + export it
ccharly
committed
fix: fix addNewKeyring
ccharly
committed
fix: properly destroy v2 instances
ccharly
committed
fix: assert v2 instances
ccharly
committed
fix: missing export
ccharly
committed
fix: re-use SelectedKeyring in withKeyring
ccharly
committed
refactor: cosmetic (move withController block)
ccharly
committed
fix: check for removed keyrings unsafe access too
ccharly
committed
refactor: cosmetic (move withController block)
ccharly
committed
chore: changelog
ccharly
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.