Conversation
:selectedAccountGroupChange on init:selectedAccountGroupChange on init
hmalik88
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We used to not persist the
selectedAccountGroupproperty before this change:selectedAccountGroupto top-level persisted state #8245As a side-effect of this new persistence, we're not re-sending
:selectedAccountGroupChangeoninitand a lot of controllers were relying on this behavior.We re-introduce this behavior so every controllers can decide how to handle that.
References
N/A
Checklist
Note
Medium Risk
Changes event-emission semantics so
selectedAccountGroupChangenow fires on everyinit/reinit, which may trigger extra startup work or duplicate handling in subscribers that assumed it only emitted on changes.Overview
Ensures
AccountTreeControlleralways publishesAccountTreeController:selectedAccountGroupChangeat the end ofinit(and thereforereinit), even when the selected group value is unchanged.Adds a regression test covering the reinit-with-same-accounts case and updates the package changelog to document the restored behavior.
Reviewed by Cursor Bugbot for commit 0689a7b. Bugbot is set up for automated code reviews on this repo. Configure here.