fix(network-enablement-controller): add Tempo to POPULAR_NETWORKS so "All popular networks" selects correctly#9069
Open
vinnyhoward wants to merge 4 commits into
Open
Conversation
…d-tempo-network-enablement
| '0x8f', // Monad (143) | ||
| '0x10e6', // MegaETH (4326) | ||
| '0x13b2', // Arc (5042) | ||
| '0x1079', // Tempo (4217) |
Contributor
There was a problem hiding this comment.
just wanna double check. Popular networks doesn't mean default right? It should appear as an "additional network"?
Just being overly cautious :)
Contributor
Author
There was a problem hiding this comment.
In this context it is a popular network, I've made that assumption because it was recently added into mobile and it appears as popular. I've attached a video below showing Tempo in popular networks. Also, its showcasing the bug explained in the PR description @Prithpal-Sooriya
If this is incorrect I'm happy to fix the issue or close the PR and come up with another solution. I just need more context on the Tempo network addition
Simulator.Screen.Recording.-.iPhone.17.-.2026-06-10.at.15.38.15.mov
Prithpal-Sooriya
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Problem: The "All popular networks" row in the network multi-selector does not highlight after being tapped for users who have the Tempo network (chain ID
4217/0x1079) configured in their wallet.Root cause: The app's
PopularList(app/util/networks/customNetworks.tsx) includes Tempo, so it shows up in the popular-networks UI viaselectPopularNetworkConfigurationsByCaipChainId. However, the controller'senableAllPopularNetworks()only enables networks listed inPOPULAR_NETWORKS(packages/network-enablement-controller/src/constants.ts), which was missing Tempo. As a result,areAllEvmNetworksSelectedstayedfalseeven after tapping "All popular networks" — leaving the aggregate row unhighlighted while every individual network row appeared highlighted instead.Migration 132 in MetaMask Mobile confirms a subset of users already have Tempo configured from prior use, so this affects real users in the wild.
Fix: Add
'0x1079'(Tempo, chain ID4217) toPOPULAR_NETWORKSso thatenableAllPopularNetworks()enables Tempo alongside the other popular networks, keeping the controller's notion of "all popular" in sync with the UI'sPopularList.Expected behavior after fix: Tapping "All popular networks" highlights the aggregate row and deselects the individual rows.
References
app/util/networks/customNetworks.tsx(MetaMask Mobile) —PopularListincludes Tempo (0x1079)packages/network-enablement-controller/src/constants.ts—POPULAR_NETWORKS(was missing Tempo)Checklist
Note
Low Risk
Single constant and changelog entry; no logic changes beyond including one more chain in the existing popular-networks list.
Overview
Adds Tempo (
0x1079, chain ID 4217) toPOPULAR_NETWORKSinconstants.tsand documents it under Unreleased in the package changelog.That aligns
enableAllPopularNetworks()(and related “all popular EVM” checks) with the client popular-networks list, so the “All popular networks” aggregate row can highlight correctly when Tempo is configured instead of leavingareAllEvmNetworksSelectedfalse.Reviewed by Cursor Bugbot for commit 98f707f. Bugbot is set up for automated code reviews on this repo. Configure here.