refactor: updated Input and TextField to align with mobile fixes#1000
Draft
brianacnguyen wants to merge 1 commit intomainfrom
Draft
refactor: updated Input and TextField to align with mobile fixes#1000brianacnguyen wants to merge 1 commit intomainfrom
brianacnguyen wants to merge 1 commit intomainfrom
Conversation
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes
Inputtypography styling (removingtext-*utility usage in favor of explicit metrics) and altersTextFieldpublic API/styling by removingTextFieldSizeand adjusting borders/heights, which may affect consumers’ layout and visual states.Overview
Updates
Inputtypography handling by introducingMAP_TEXT_VARIANT_INPUT_METRICS(fontSize/letterSpacing without lineHeight) and applying it directly, keeping the iOS placeholderlineHeight: 0workaround scoped to placeholder-visible state.Refactors
TextFieldto a fixed 48px height (removingTextFieldSizeand related exports/docs/stories), tweaks container styling (muted background and new border color logic for focus/error/disabled), forces the innerInputto be single-line with a 46px height, and addsstartAccessoryTestID/endAccessoryTestIDwith new/updated tests and Storybook using controlled wrappers.Written by Cursor Bugbot for commit f0b95db. This will update automatically on new commits. Configure here.