fix: Update border radius of AvatarBase.XS to improve visual cohesion#841
Open
amandaye0h wants to merge 2 commits intomainfrom
Open
fix: Update border radius of AvatarBase.XS to improve visual cohesion#841amandaye0h wants to merge 2 commits intomainfrom
amandaye0h wants to merge 2 commits intomainfrom
Conversation
Contributor
📖 Storybook Preview |
amandaye0h
changed the title
Contributor
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
Well done on updating both react and react native instances. I've left a couple questions
Comment on lines
+3
to
13
| import { fileURLToPath } from 'url'; | ||
|
|
||
| /** | ||
| * This function is used to resolve the absolute path of a package. | ||
| * It is needed in projects that are set up within a monorepo. | ||
| * | ||
| * @param value | ||
| */ | ||
| function getAbsolutePath(value: string): any { | ||
| return dirname(require.resolve(join(value, 'package.json'))); | ||
| function getAbsolutePath(value: string): string { | ||
| return value; | ||
| } |
Contributor
There was a problem hiding this comment.
What is the reason for this change?
| string | ||
| > = { | ||
| [AvatarBaseSize.Xs]: 'rounded-sm', // 4px | ||
| [AvatarBaseSize.Xs]: 'rounded-[5px]', // 5px |
Contributor
There was a problem hiding this comment.
Is there any reason why we can't stay within the tailwind system? Is this the only place we should be using a 5px border radius?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the
borderRadiusof theAvatarBase.XSfrom4pxto5pxto improve visual cohesion with our typography. At4px, the icons looked too sharp. This change makes our icons feel like they scale more naturally.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Figma file has been updated here
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates AvatarBase XS square radius from 4px to 5px in both web and React Native; simplifies Storybook getAbsolutePath config.
rounded-sm) to 5px (rounded-[5px]) in:packages/design-system-react/src/components/AvatarBase/AvatarBase.constants.tspackages/design-system-react-native/src/components/AvatarBase/AvatarBase.constants.tsapps/storybook-react/.storybook/main.ts: SimplifygetAbsolutePath()to return the value (typedstring) and addfileURLToPathimport.Written by Cursor Bugbot for commit d29beb9. This will update automatically on new commits. Configure here.