feat: add HeaderBase component#902
Merged
georgewrmarshall merged 11 commits intoMetaMask:mainfrom Feb 20, 2026
Merged
Conversation
Collaborator
Author
|
CI fails because it depends on deps re-arrangement from this PR: #901 |
kirillzyusko
force-pushed
the
feat/add-header-base
branch
from
7cd3e87 to
ffbeef7
Compare
Collaborator
Author
|
@georgewrmarshall this PR is ready for review 👀 |
kirillzyusko
force-pushed
the
feat/add-header-base
branch
from
ffbeef7 to
2d19692
Compare
Contributor
|
My apologies but I think this is duplicated from #908 |
Collaborator
Author
|
Ah, okay But feel free to merge your PR and close this 🙂 |
packages/design-system-react-native/src/components/HeaderBase/HeaderBase.constants.ts
Outdated
Show resolved
Hide resolved
brianacnguyen
requested changes
Feb 18, 2026
Contributor
brianacnguyen
left a comment
brianacnguyen
left a comment
There was a problem hiding this comment.
can you remove the testid const?
Collaborator
Author
|
Done @brianacnguyen 🙌 |
brianacnguyen
previously approved these changes
Feb 18, 2026
georgewrmarshall
previously approved these changes
Feb 18, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
kirillzyusko
dismissed stale reviews from georgewrmarshall and brianacnguyen
via
9f021f4
Contributor
|
@kirillzyusko can you resolve the cursor comments? |
packages/design-system-react-native/src/components/HeaderBase/HeaderBase.tsx
Outdated
Show resolved
Hide resolved
brianacnguyen
previously approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Can remove this image in a follow up PR they tend to become out of date
Comment on lines
+45
to
+51
| export const TwClassName = { | ||
| render: () => ( | ||
| <HeaderBase twClassName="bg-info-default px-4"> | ||
| Header with Custom Styles | ||
| </HeaderBase> | ||
| ), | ||
| }; |
Contributor
There was a problem hiding this comment.
Probably don't need this story can be removed in a folllow up PR
georgewrmarshall
approved these changes
Feb 20, 2026
georgewrmarshall
added a commit
that referenced
this pull request
Feb 20, 2026
## Summary Reverts the failed Release 20.0.0 (#921) to redo it properly with complete changelogs and correct yarn.lock. ## Context Release 20.0.0 was merged to main but the publish workflow failed due to a yarn.lock issue: - **Failed workflow:** https://github.com/MetaMask/metamask-design-system/actions/runs/22198282954 - **Root cause:** yarn.lock not updated when peer dependency changed After the release was merged, 7 additional PRs were merged to main: 1. Label component (#907) 2. HeaderBase component (#902) 3. Skeleton (#891) 4. Card (#923) 5. BottomSheetFooter (#899) 6. Toast (#892) 7. Input component (#909) ## Why Revert? To maintain clean version history and proper changelogs: - Release 20.0.0 was never published to NPM (latest is 19.0.0) - The 7 PRs merged after are not documented in Release 20.0.0 changelog - Reverting allows us to create a proper Release 20.0.0 that includes ALL changes ## Changes This PR reverts commit `45004196` which: - Restores package versions to pre-release state (8.1.1, 0.7.0, 0.6.0, etc.) - Restores root package.json version from 20.0.0 to 19.0.0 - Removes Release 20.0.0 changelog entries ## Next Steps After this is merged: 1. Create new `release/20.0.0` branch using standard release process 2. Include all changes (original + 7 PRs) in changelogs 3. **Run `yarn install` to update yarn.lock** 4. Merge new Release 20.0.0 PR 5. Publish workflow will succeed with correct lockfile 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
HeaderBasecomponent.Related issues
Fixes:
Manual testing steps
HeaderBaseworks as expectedScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Mostly additive UI component work with tests/docs; main risk is subtle layout/centering or safe-area mocking side effects across the Jest suite.
Overview
Adds a new
HeaderBasecomponent todesign-system-react-native, providing a centered header title with optional start/end accessories or icon buttons, optional safe-area top inset handling, and Tailwind class/style customization.Registers
HeaderBasein the public exports and Storybook, and adds comprehensive unit tests + README docs. Updates Jest setup to globally mockreact-native-safe-area-context(and removes a local mock inToast.test.tsx) to stabilize safe-area dependent tests.Written by Cursor Bugbot for commit c7a11bd. This will update automatically on new commits. Configure here.