chore: Added HeaderBase to DSR and DSRN #908
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // External dependencies. | ||
| import { TextVariant } from '../Text'; | ||
|
|
||
| /** | ||
| * Text variant used for the header title when children is a string. | ||
| */ | ||
| export const HEADERBASE_TITLE_TEXT_VARIANT = TextVariant.HeadingSm; | ||
|
|
||
| /** | ||
| * Default test IDs for HeaderBase component. | ||
| */ | ||
| export const HEADERBASE_TEST_ID = 'header'; | ||
| export const HEADERBASE_TITLE_TEST_ID = 'header-title'; |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| import type { Meta, StoryObj } from '@storybook/react-native'; | ||
| import React from 'react'; | ||
|
|
||
| import { Box } from '../Box'; | ||
| import { ButtonIcon, ButtonIconSize } from '../ButtonIcon'; | ||
| import { IconName } from '../Icon'; | ||
| import { Text, TextVariant } from '../Text'; | ||
|
|
||
| import HeaderBase from './HeaderBase'; | ||
| import type { HeaderBaseProps } from './HeaderBase.types'; | ||
|
|
||
| const meta: Meta<HeaderBaseProps> = { | ||
| title: 'Components/HeaderBase', | ||
| component: HeaderBase, | ||
| argTypes: { | ||
| children: { | ||
| control: 'text', | ||
| }, | ||
| twClassName: { | ||
| control: 'text', | ||
| }, | ||
| includesTopInset: { | ||
| control: 'boolean', | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; | ||
|
|
||
| type Story = StoryObj<HeaderBaseProps>; | ||
|
|
||
| const noop = (): void => undefined; | ||
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| children: 'Header Title', | ||
| }, | ||
| render: (args) => <HeaderBase {...args} />, | ||
| }; | ||
|
|
||
| export const TwClassName: Story = { | ||
| render: () => ( | ||
| <HeaderBase twClassName="bg-info-default px-4"> | ||
| Header with Custom Styles | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
Comment on lines
+41
to
+47
Contributor
There was a problem hiding this comment. Don't think we need this story for the twClassName prop just let the readme template explain it. If this was created by the cursor rule, let's update the rule to exclude these props that are taken care of by readme |
||
|
|
||
| export const StartButtonIconProps: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| startButtonIconProps={{ | ||
| iconName: IconName.ArrowLeft, | ||
| onPress: noop, | ||
| }} | ||
| > | ||
| With Start Button | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const EndButtonIconProps: Story = { | ||
|
Contributor
There was a problem hiding this comment. maybe we can be a bit more selective on stories and improve the cursor rule here to exclude prop object, twClassName and style props |
||
| render: () => ( | ||
| <HeaderBase | ||
| endButtonIconProps={[ | ||
| { | ||
| iconName: IconName.Close, | ||
| onPress: noop, | ||
| }, | ||
| ]} | ||
| > | ||
| With End Button | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const MultipleEndButtonIconProps: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| endButtonIconProps={[ | ||
| { | ||
| iconName: IconName.Close, | ||
| onPress: noop, | ||
| }, | ||
| { | ||
| iconName: IconName.Search, | ||
| onPress: noop, | ||
| }, | ||
| { | ||
| iconName: IconName.Setting, | ||
| onPress: noop, | ||
| }, | ||
| ]} | ||
| > | ||
| Multiple End Buttons | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const StartAccessory: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| startAccessory={ | ||
| <ButtonIcon | ||
| iconName={IconName.ArrowLeft} | ||
| size={ButtonIconSize.Md} | ||
| onPress={noop} | ||
| /> | ||
| } | ||
| > | ||
| With Start Accessory | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const EndAccessory: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| endAccessory={ | ||
| <ButtonIcon | ||
| iconName={IconName.Close} | ||
| size={ButtonIconSize.Md} | ||
| onPress={noop} | ||
| /> | ||
| } | ||
| > | ||
| With End Accessory | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const BothAccessories: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| startAccessory={ | ||
| <ButtonIcon | ||
| iconName={IconName.ArrowLeft} | ||
| size={ButtonIconSize.Md} | ||
| onPress={noop} | ||
| /> | ||
| } | ||
| endAccessory={ | ||
| <ButtonIcon | ||
| iconName={IconName.Close} | ||
| size={ButtonIconSize.Md} | ||
| onPress={noop} | ||
| /> | ||
| } | ||
| > | ||
| Both Accessories | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
|
|
||
| export const Children: Story = { | ||
| render: () => ( | ||
| <HeaderBase | ||
| startButtonIconProps={{ | ||
| iconName: IconName.ArrowLeft, | ||
| onPress: noop, | ||
| }} | ||
| > | ||
| <Box twClassName="items-center"> | ||
| <Text variant={TextVariant.HeadingSm}>Custom Title</Text> | ||
| <Text variant={TextVariant.BodySm}>Subtitle text</Text> | ||
| </Box> | ||
| </HeaderBase> | ||
| ), | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove image as it can become out dated