Conversation
📖 Storybook Preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| variant: TextVariant.BodySm, | ||
| color: TextColor.TextAlternative, | ||
| twClassName: `flex-1 ${textProps?.twClassName ?? ''}`.trim(), | ||
| }} |
There was a problem hiding this comment.
textProps spread order prevents user overrides
High Severity
The textProps object spreads the user-provided textProps first, then hardcodes variant and color after, meaning the explicit defaults always win. Users can never override variant or color via textProps. The defaults need to come before the spread ({ variant: BodySm, color: TextAlternative, ...textProps, twClassName: ... }) so user-supplied values take precedence. This breaks the TextPropsOverride story and the "merges textProps over defaults" test, and contradicts the README which states overrides are supported.
📖 Storybook Preview |
1 participant
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Adds several new reusable UI components (headers, sections, search field) and extends
ButtonIconsizing, which may affect consumers’ layouts and interactions. Risk is moderate because changes are mostly presentation-level but touch shared design-system primitives and Storybook registration.Overview
Adds new design-system components for React Native:
Attribution,HeaderRoot,HeaderSearch,HeaderStandard,HeaderStandardAnimated(+useHeaderStandardAnimated),KeyValuePair,SectionBase,SectionStandard,SectionInsights,SectionSocial, andTextFieldSearch, each with accompanying tests, Storybook stories, and README docs.Updates shared primitives to support these patterns: introduces
ButtonIconSize.Xsmappings (including tests/docs), adjustsButtonFilterbase styling, and registers the new stories in Storybook.Written by Cursor Bugbot for commit df7f122. This will update automatically on new commits. Configure here.