docs: add non-blocking platform PR process guide#995
Draft
georgewrmarshall wants to merge 2 commits intomainfrom
Draft
docs: add non-blocking platform PR process guide#995georgewrmarshall wants to merge 2 commits intomainfrom
georgewrmarshall wants to merge 2 commits intomainfrom
Conversation
Document how MMDS reviews consumer PRs without blocking merge: local Tailwind-style overrides, TODO + @MetaMask/design-system-engineers, and Slack intake. Includes CONF-1099 / extension #41196 reference. Made-with: Cursor
Contributor
📖 Storybook Preview |
- Reframe for all contributing teams (extension/mobile) with squad list - Add Shaun Bent article link and platform vs feature pace framing - Clarify Slack handoff for #metamask-design-system and user-validated patterns - Streamline TODO tracking and process table wording Made-with: Cursor
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
docs/non-blocking-platform-pr-process.md, a process guide for reviewing consumer-repo PRs (e.g. extension, mobile) when they introduce UI that touches design-system-shaped components but MMDS has not yet defined the variant, token, or API (e.g. first warning styling on aTextField).The doc covers:
border-warning-defaultrather than new SCSS modifiers where appropriate); add a grep-friendly TODO tagging@MetaMask/design-system-engineers; open a Slack thread for async DS discussion; follow up in MMDS and consumer repos once canonical behavior exists.recipient-input.tsx.Related issues
Fixes: (none — documentation only)
Manual testing steps
docs/non-blocking-platform-pr-process.mdin the repo or on GitHub and confirm headings, links, and tables render as expected.yarn prettier --check docs/non-blocking-platform-pr-process.md.Screenshots/Recordings
Documentation-only change; no UI.
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Documentation-only change that adds a process guide; no runtime behavior, APIs, or data flows are modified.
Overview
Adds a new doc,
docs/non-blocking-platform-pr-process.md, defining a non-blocking review process for extension/mobile PRs that need UI beyond current MMDS support.The guide standardizes using localized overrides plus a grep-friendly
// TODO: @MetaMask/design-system-engineers:marker and a Slack handoff to track gaps and follow up asynchronously after merge.Written by Cursor Bugbot for commit acae346. This will update automatically on new commits. Configure here.