Skip to content

Update candlestick icon with smaller size variant#998

Draft
brianacnguyen wants to merge 1 commit intomainfrom
cursor/candlestick-icon-update-2b10
Draft

Update candlestick icon with smaller size variant#998
brianacnguyen wants to merge 1 commit intomainfrom
cursor/candlestick-icon-update-2b10

Conversation

@brianacnguyen
Copy link
Contributor

Description

Updates the candlestick icon SVG to use a smaller size variant that matches the diagram icon at Md scale. This change was requested by the design team to ensure visual consistency when both icons are used together in time range controls (e.g., Asset Details).

Changes:

  • Updated candlestick.svg in @metamask/design-system-react package
  • Updated candlestick.svg in @metamask/design-system-react-native package
  • Regenerated the React icon component via yarn generate-icons

Related issues

Fixes: Design team request via Slack (#metamask-design-system)

Manual testing steps

  1. Run Storybook (yarn storybook)
  2. Navigate to the Icon component
  3. Find the Candlestick icon and verify it appears smaller/matches the Diagram icon at Md size

Screenshots/Recordings

Before

The candlestick icon appeared larger than the diagram icon at the same size.

After

The candlestick icon now matches the diagram icon size at Md scale.

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Slack Thread

Open in Web Open in Cursor 

- Updated SVG in design-system-react package
- Updated SVG in design-system-react-native package
- Regenerated React icon component

The new icon has smaller candlestick elements to match the diagram icon size at Md scale.

Co-authored-by: Brian August Nguyen <brianacnguyen@gmail.com>
@github-actions
Copy link
Contributor

📖 Storybook Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants