Update candlestick icon with smaller size variant#998
Draft
brianacnguyen wants to merge 1 commit intomainfrom
Draft
Update candlestick icon with smaller size variant#998brianacnguyen wants to merge 1 commit intomainfrom
brianacnguyen wants to merge 1 commit intomainfrom
Conversation
- Updated SVG in design-system-react package - Updated SVG in design-system-react-native package - Regenerated React icon component The new icon has smaller candlestick elements to match the diagram icon size at Md scale. Co-authored-by: Brian August Nguyen <brianacnguyen@gmail.com>
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the candlestick icon SVG to use a smaller size variant that matches the diagram icon at Md scale. This change was requested by the design team to ensure visual consistency when both icons are used together in time range controls (e.g., Asset Details).
Changes:
candlestick.svgin@metamask/design-system-reactpackagecandlestick.svgin@metamask/design-system-react-nativepackageyarn generate-iconsRelated issues
Fixes: Design team request via Slack (#metamask-design-system)
Manual testing steps
yarn storybook)Screenshots/Recordings
Before
The candlestick icon appeared larger than the diagram icon at the same size.
After
The candlestick icon now matches the diagram icon size at Md scale.
Pre-merge author checklist
Pre-merge reviewer checklist
Slack Thread