feat(assets): wire isDeprecated for multichain controllers#43336
Open
Prithpal-Sooriya wants to merge 6 commits into
Open
feat(assets): wire isDeprecated for multichain controllers#43336Prithpal-Sooriya wants to merge 6 commits into
Prithpal-Sooriya wants to merge 6 commits into
Conversation
Add isDeprecated callbacks to MultichainAssetsRatesController and MultichainBalancesController initialization, driven by the assetsUnifyState remote feature flag deprecatedControllers list. Uses @metamask-previews/assets-controllers@108.5.0-preview-513faa49e from MetaMask/core#9044. Related: MetaMask/core#9044 Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mm-token-exchange-service
Bot
added
team-assets
INVALID-PR-TEMPLATE
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b2f9521. Configure here.
mm-token-exchange-service
Bot
removed
the
INVALID-PR-TEMPLATE
Prithpal-Sooriya
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [b2f9521]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 7 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Contributor
Builds ready [f3073b8]
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
When isDeprecated is true in test environments, MultichainAssetsRatesController and MultichainBalancesController clear conversionRates, historicalPrices, and balances to empty objects. Update metrics state snapshots and state-logs.json to match, following the TokenListController pattern from #43108. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +2 -161)
🧪 @MetaMask/qa (1 files, +2 -161)
|
Contributor
Builds ready [430a91c] [reused from f3073b8]
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sentry maskObject reports typeof for MultichainBalancesController.balances
and MultichainAssetsRatesController rate fields, so deprecated empty state
still serializes as "object" — unlike TokenListController.tokensChainsCache
which uses an AllProperties sub-mask and snapshots as {}.
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Contributor
Builds ready [a5f6c15]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 9 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires the
isDeprecatedconstructor callback forMultichainAssetsRatesControllerandMultichainBalancesControllerin the extension, following the same pattern used forTokenListControllerin #43108 and the core implementation in MetaMask/core#9044.When the
assetsUnifyStateremote feature flag lists a controller indeprecatedControllers, the callback returnstrueand the controller stops issuing Snap requests and clears its persisted state.This PR uses the preview build from core#9044:
@metamask-previews/assets-controllers@108.5.0-preview-513faa49eChangelog
CHANGELOG entry: null
Related issues
Related: MetaMask/core#9044
Manual testing steps
yarn startoryarn build:test).assetsUnifyState.deprecatedControllersincludingMultichainAssetsRatesControllerandMultichainBalancesController, verify multichain conversion rates and balances are not fetched via Snap.deprecatedControllers, verify existing multichain balance/rate behavior is unchanged.Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist