Skip to content

refactor(analytics): migrate accounts identity metrics consumers#43433

Merged
gauthierpetetin merged 2 commits into
mainfrom
refactor/analytics-phase-b-accounts
Jun 15, 2026
Merged

refactor(analytics): migrate accounts identity metrics consumers#43433
gauthierpetetin merged 2 commits into
mainfrom
refactor/analytics-phase-b-accounts

Conversation

@gauthierpetetin

@gauthierpetetin gauthierpetetin commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Part 5 of the Analytics Phase B split (supersedes monolithic #43406).

Owner: @MetaMask/accounts-engineers

Reason: Accounts identity init and backup-and-sync tests still reference legacy metrics fields.

Solution: Migrate authentication controller init/messenger and backup-and-sync tests to canonical analytics selectors.

Depends on: #43430

Changelog

CHANGELOG entry: null

Related issues

Part of https://github.com/MetaMask/MetaMask-planning/issues/7331

Manual testing steps

  1. Run unit tests for backup-and-sync components
  2. Verify backup and sync toggle flows still work after building with yarn start

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-extension-platform Extension Platform team label Jun 11, 2026
@mm-token-exchange-service

mm-token-exchange-service Bot commented Jun 11, 2026

Copy link
Copy Markdown

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (5 files, +11 -11)
  • 📁 app/
    • 📁 scripts/
      • 📁 messenger-client-init/
        • 📁 identity/
          • 📄 authentication-controller-init.ts +2 -4
        • 📁 messengers/
          • 📁 identity/
            • 📄 authentication-controller-messenger.ts +3 -4
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 identity/
          • 📁 backup-and-sync-features-toggles/
            • 📄 backup-and-sync-features-toggles.test.tsx +2 -1
          • 📁 backup-and-sync-toggle/
            • 📄 backup-and-sync-toggle.test.tsx +2 -1
        • 📁 modals/
          • 📁 identity/
            • 📁 turn-on-backup-and-sync-modal/
              • 📄 turn-on-backup-and-sync-modal.test.tsx +2 -1

@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c70124d]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 7 warn · 🔴 0 fail)

Baseline (latest main): 1ab4918 | Date: 6/11/2026 | Pipeline: 27327236366 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/inp: +33%
  • confirmTx/inp: +50%
  • bridgeUserActions/bridge_load_page: +23%
  • bridgeUserActions/bridge_load_asset_picker: -13%
  • bridgeUserActions/longTaskCount: -38%
  • bridgeUserActions/longTaskTotalDuration: -25%
  • bridgeUserActions/tbt: +12%
  • bridgeUserActions/inp: +29%
  • loadNewAccount/load_new_account: +19%
  • loadNewAccount/total: +19%
  • loadNewAccount/inp: +50%
  • loadNewAccount/fcp: -64%
  • loadNewAccount/lcp: +1106%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/inp: -10%
  • confirmTx/lcp: +1224%
  • bridgeUserActions/bridge_load_page: +130%
  • bridgeUserActions/bridge_load_asset_picker: +72%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +37%
  • bridgeUserActions/inp: -22%
  • bridgeUserActions/fcp: +10%
  • bridgeUserActions/lcp: +1195%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstPaint: -11%
  • startupPowerUserHome/numNetworkReqs: +39%
  • startupPowerUserHome/domInteractive: -16%
  • startupPowerUserHome/backgroundConnect: +43%
  • startupPowerUserHome/setupStore: -11%
  • startupPowerUserHome/fcp: -17%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 504ms
  • 🟡 startupPowerUserHome/LCP: p75 2.8s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -91%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -94%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -90%
  • onboardingNewWallet/srpButtonToPwForm: -19%
  • onboardingNewWallet/createPwToRecoveryScreen: -17%
  • onboardingNewWallet/skipBackupToMetricsScreen: -13%
  • onboardingNewWallet/doneButtonToAssetList: -56%
  • onboardingNewWallet/longTaskCount: -38%
  • onboardingNewWallet/longTaskTotalDuration: -57%
  • onboardingNewWallet/longTaskMaxDuration: -23%
  • onboardingNewWallet/tbt: -80%
  • onboardingNewWallet/total: -49%
  • assetDetails/assetClickToPriceChart: -28%
  • assetDetails/longTaskCount: +400%
  • assetDetails/longTaskTotalDuration: +667%
  • assetDetails/longTaskMaxDuration: +667%
  • assetDetails/total: -28%
  • assetDetails/lcp: +13%
  • assetDetails/cls: -94%
  • solanaAssetDetails/assetClickToPriceChart: -29%
  • solanaAssetDetails/total: -29%
  • solanaAssetDetails/cls: -84%
  • importSrpHome/loginToHomeScreen: -19%
  • importSrpHome/openAccountMenuAfterLogin: +50%
  • importSrpHome/homeAfterImportWithNewWallet: -34%
  • importSrpHome/longTaskCount: -24%
  • importSrpHome/longTaskTotalDuration: -23%
  • importSrpHome/longTaskMaxDuration: -19%
  • importSrpHome/tbt: -23%
  • importSrpHome/total: -26%
  • importSrpHome/inp: -29%
  • importSrpHome/fcp: +13%
  • importSrpHome/cls: -40%
  • sendTransactions/openSendPageFromHome: +56%
  • sendTransactions/reviewTransactionToConfirmationPage: +14%
  • sendTransactions/longTaskCount: +11%
  • sendTransactions/longTaskTotalDuration: +28%
  • sendTransactions/tbt: +58%
  • sendTransactions/total: +17%
  • sendTransactions/inp: -30%
  • sendTransactions/cls: -87%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/INP: p75 240ms
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 258 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 188 Bytes (0%)

Base automatically changed from refactor/analytics-phase-b-foundation to main June 11, 2026 14:49
@gauthierpetetin gauthierpetetin force-pushed the refactor/analytics-phase-b-accounts branch from c70124d to a7a8a60 Compare June 11, 2026 14:53
@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a7a8a60]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)

Baseline (latest main): 86afca4 | Date: 6/11/2026 | Pipeline: 27355753642 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -15%
  • loadNewAccount/total: -15%
  • loadNewAccount/inp: -12%
  • loadNewAccount/cls: -17%
  • confirmTx/inp: +12%
  • bridgeUserActions/longTaskCount: +67%
  • bridgeUserActions/longTaskTotalDuration: +47%
  • bridgeUserActions/tbt: +15%
  • bridgeUserActions/inp: -39%
  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: -12%
  • loadNewAccount/fcp: -45%
  • loadNewAccount/lcp: +1119%
  • confirmTx/confirm_tx: +13%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +13%
  • confirmTx/fcp: +11%
  • confirmTx/lcp: +1153%
  • bridgeUserActions/bridge_load_page: +213%
  • bridgeUserActions/bridge_load_asset_picker: +43%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +29%
  • bridgeUserActions/inp: -39%
  • bridgeUserActions/lcp: +1275%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: +49%
  • startupPowerUserHome/inp: -15%
  • startupStandardHome/inp: +100%
  • startupPowerUserHome/domInteractive: -27%
  • startupPowerUserHome/backgroundConnect: -24%
  • startupPowerUserHome/fcp: -26%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 472ms
  • 🟡 startupPowerUserHome/LCP: p75 3.1s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +16%
  • onboardingImportWallet/confirmSrpToPwForm: +15%
  • onboardingImportWallet/pwFormToMetricsScreen: +13%
  • onboardingImportWallet/metricsToWalletReadyScreen: +29%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -44%
  • onboardingImportWallet/longTaskTotalDuration: -84%
  • onboardingImportWallet/longTaskMaxDuration: -89%
  • onboardingImportWallet/tbt: -98%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • onboardingNewWallet/doneButtonToAssetList: -21%
  • onboardingNewWallet/longTaskCount: -44%
  • onboardingNewWallet/longTaskTotalDuration: -42%
  • onboardingNewWallet/longTaskMaxDuration: -12%
  • onboardingNewWallet/tbt: -38%
  • onboardingNewWallet/total: -17%
  • solanaAssetDetails/assetClickToPriceChart: -58%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -58%
  • solanaAssetDetails/cls: -93%
  • importSrpHome/loginToHomeScreen: -11%
  • importSrpHome/openAccountMenuAfterLogin: +17%
  • importSrpHome/homeAfterImportWithNewWallet: -37%
  • importSrpHome/longTaskCount: -21%
  • importSrpHome/longTaskTotalDuration: -29%
  • importSrpHome/longTaskMaxDuration: -19%
  • importSrpHome/tbt: -35%
  • importSrpHome/total: -34%
  • importSrpHome/inp: -35%
  • sendTransactions/openSendPageFromHome: -39%
  • sendTransactions/selectTokenToSendFormLoaded: -25%
  • sendTransactions/longTaskTotalDuration: +22%
  • sendTransactions/longTaskMaxDuration: +18%
  • sendTransactions/tbt: +55%
  • sendTransactions/inp: -29%
  • sendTransactions/lcp: -10%
  • sendTransactions/cls: -73%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 259 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 188 Bytes (0%)

@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [df32886] [reused from a7a8a60]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)

Baseline (latest main): 86afca4 | Date: 6/11/2026 | Pipeline: 27360415068 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -15%
  • loadNewAccount/total: -15%
  • loadNewAccount/inp: -12%
  • loadNewAccount/cls: -17%
  • confirmTx/inp: +12%
  • bridgeUserActions/longTaskCount: +67%
  • bridgeUserActions/longTaskTotalDuration: +47%
  • bridgeUserActions/tbt: +15%
  • bridgeUserActions/inp: -39%
  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: -12%
  • loadNewAccount/fcp: -45%
  • loadNewAccount/lcp: +1119%
  • confirmTx/confirm_tx: +13%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +13%
  • confirmTx/fcp: +11%
  • confirmTx/lcp: +1153%
  • bridgeUserActions/bridge_load_page: +213%
  • bridgeUserActions/bridge_load_asset_picker: +43%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +29%
  • bridgeUserActions/inp: -39%
  • bridgeUserActions/lcp: +1275%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: +49%
  • startupPowerUserHome/inp: -15%
  • startupStandardHome/inp: +100%
  • startupPowerUserHome/domInteractive: -27%
  • startupPowerUserHome/backgroundConnect: -24%
  • startupPowerUserHome/fcp: -26%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 472ms
  • 🟡 startupPowerUserHome/LCP: p75 3.1s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +16%
  • onboardingImportWallet/confirmSrpToPwForm: +15%
  • onboardingImportWallet/pwFormToMetricsScreen: +13%
  • onboardingImportWallet/metricsToWalletReadyScreen: +29%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -44%
  • onboardingImportWallet/longTaskTotalDuration: -84%
  • onboardingImportWallet/longTaskMaxDuration: -89%
  • onboardingImportWallet/tbt: -98%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • onboardingNewWallet/doneButtonToAssetList: -21%
  • onboardingNewWallet/longTaskCount: -44%
  • onboardingNewWallet/longTaskTotalDuration: -42%
  • onboardingNewWallet/longTaskMaxDuration: -12%
  • onboardingNewWallet/tbt: -38%
  • onboardingNewWallet/total: -17%
  • solanaAssetDetails/assetClickToPriceChart: -58%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -58%
  • solanaAssetDetails/cls: -93%
  • importSrpHome/loginToHomeScreen: -11%
  • importSrpHome/openAccountMenuAfterLogin: +17%
  • importSrpHome/homeAfterImportWithNewWallet: -37%
  • importSrpHome/longTaskCount: -21%
  • importSrpHome/longTaskTotalDuration: -29%
  • importSrpHome/longTaskMaxDuration: -19%
  • importSrpHome/tbt: -35%
  • importSrpHome/total: -34%
  • importSrpHome/inp: -35%
  • sendTransactions/openSendPageFromHome: -39%
  • sendTransactions/selectTokenToSendFormLoaded: -25%
  • sendTransactions/longTaskTotalDuration: +22%
  • sendTransactions/longTaskMaxDuration: +18%
  • sendTransactions/tbt: +55%
  • sendTransactions/inp: -29%
  • sendTransactions/lcp: -10%
  • sendTransactions/cls: -73%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 71 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

Refresh slice from main-synced monolithic branch.
@gauthierpetetin gauthierpetetin force-pushed the refactor/analytics-phase-b-accounts branch from df32886 to d2192c8 Compare June 12, 2026 04:32
@github-actions github-actions Bot added size-S and removed size-M labels Jun 12, 2026
@metamaskbotv2

metamaskbotv2 Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d2192c8]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 1 fail)

Baseline (latest main): 5befce5 | Date: 6/12/2026 | Pipeline: 27394668470 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 fcp(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5 🔴 1
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -30%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: -30%
  • loadNewAccount/lcp: -63%
  • confirmTx/longTaskTotalDuration: -11%
  • confirmTx/longTaskMaxDuration: -12%
  • confirmTx/inp: -20%
  • bridgeUserActions/bridge_load_asset_picker: +16%
  • loadNewAccount/load_new_account: +427%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: +427%
  • loadNewAccount/inp: -39%
  • loadNewAccount/lcp: +342%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -11%
  • confirmTx/lcp: +1091%
  • bridgeUserActions/bridge_load_page: +153%
  • bridgeUserActions/bridge_load_asset_picker: +82%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +202%
  • bridgeUserActions/inp: -23%
  • bridgeUserActions/lcp: +1099%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/setupStore: +13%
  • startupStandardHome/inp: +25%
  • startupPowerUserHome/backgroundConnect: -32%
  • startupPowerUserHome/setupStore: +30%
  • startupPowerUserHome/numNetworkReqs: +10%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 544ms
  • 🟡 startupPowerUserHome/LCP: p75 2.9s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -19%
  • onboardingImportWallet/confirmSrpToPwForm: -15%
  • onboardingImportWallet/pwFormToMetricsScreen: -20%
  • onboardingImportWallet/metricsToWalletReadyScreen: -15%
  • onboardingImportWallet/doneButtonToHomeScreen: -90%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -99%
  • onboardingImportWallet/longTaskCount: -100%
  • onboardingImportWallet/longTaskTotalDuration: -100%
  • onboardingImportWallet/longTaskMaxDuration: -100%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -89%
  • onboardingNewWallet/srpButtonToPwForm: +11%
  • onboardingNewWallet/doneButtonToAssetList: -24%
  • onboardingNewWallet/longTaskCount: -55%
  • onboardingNewWallet/longTaskTotalDuration: -40%
  • onboardingNewWallet/longTaskMaxDuration: -35%
  • onboardingNewWallet/tbt: -77%
  • onboardingNewWallet/total: -22%
  • solanaAssetDetails/assetClickToPriceChart: -42%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/total: -42%
  • solanaAssetDetails/inp: -35%
  • solanaAssetDetails/cls: -92%
  • importSrpHome/loginToHomeScreen: -13%
  • importSrpHome/openAccountMenuAfterLogin: +63%
  • importSrpHome/homeAfterImportWithNewWallet: -34%
  • importSrpHome/longTaskCount: -27%
  • importSrpHome/longTaskTotalDuration: -17%
  • importSrpHome/tbt: -27%
  • importSrpHome/total: -28%
  • importSrpHome/inp: -16%
  • sendTransactions/openSendPageFromHome: +32%
  • sendTransactions/selectTokenToSendFormLoaded: +28%
  • sendTransactions/inp: -23%
  • sendTransactions/lcp: +16%
  • sendTransactions/cls: -89%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 importSrpHome/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 71 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@gauthierpetetin gauthierpetetin marked this pull request as ready for review June 15, 2026 03:34
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner June 15, 2026 03:34
@gauthierpetetin gauthierpetetin requested a review from Copilot June 15, 2026 03:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the Analytics Phase B migration by removing remaining usage of legacy UI metrics fields in identity-related unit tests and switching the Authentication controller’s initialization messenger wiring to read the canonical analytics state.

Changes:

  • Updated backup-and-sync UI unit test fixtures to use completedMetaMetricsOnboarding and optedIn instead of participateInMetaMetrics.
  • Migrated AuthenticationController init messenger permissions from MetaMetricsController:getMetaMetricsId to AnalyticsController:getState.
  • Updated AuthenticationControllerInit to derive the MetaMetrics ID from AnalyticsController state during initialization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ui/components/app/modals/identity/turn-on-backup-and-sync-modal/turn-on-backup-and-sync-modal.test.tsx Updates mocked Redux state to use canonical analytics consent fields.
ui/components/app/identity/backup-and-sync-toggle/backup-and-sync-toggle.test.tsx Updates mocked Redux state to use canonical analytics consent fields.
ui/components/app/identity/backup-and-sync-features-toggles/backup-and-sync-features-toggles.test.tsx Updates mocked Redux state to use canonical analytics consent fields.
app/scripts/messenger-client-init/messengers/identity/authentication-controller-messenger.ts Switches allowed init actions to AnalyticsController:getState.
app/scripts/messenger-client-init/identity/authentication-controller-init.ts Reads analyticsId from AnalyticsController:getState to supply getMetaMetricsId.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/scripts/messenger-client-init/identity/authentication-controller-init.ts Outdated
Align with remote-feature-flag-controller-init by reading analyticsId
directly from AnalyticsController:getState without a cast or empty-string
fallback.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mm-token-exchange-service

Copy link
Copy Markdown
Builds ready [9da7aad]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 10 warn · 🔴 0 fail)

Baseline (latest main): 5682526 | Date: 6/13/2026 | Pipeline: 27525292617 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +27%
  • loadNewAccount/total: +27%
  • loadNewAccount/inp: -12%
  • confirmTx/longTaskCount: +33%
  • confirmTx/inp: -10%
  • bridgeUserActions/bridge_load_page: -25%
  • bridgeUserActions/tbt: -18%
  • bridgeUserActions/inp: -24%
  • loadNewAccount/load_new_account: +79%
  • loadNewAccount/total: +79%
  • loadNewAccount/inp: +57%
  • loadNewAccount/fcp: -50%
  • loadNewAccount/lcp: +1165%
  • confirmTx/confirm_tx: +13%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +13%
  • confirmTx/fcp: +16%
  • confirmTx/lcp: +1167%
  • bridgeUserActions/bridge_load_page: +82%
  • bridgeUserActions/bridge_load_asset_picker: +22%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +184%
  • bridgeUserActions/inp: -24%
  • bridgeUserActions/fcp: -49%
  • bridgeUserActions/lcp: +1192%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/domInteractive: +18%
  • startupPowerUserHome/backgroundConnect: +11%
  • startupPowerUserHome/numNetworkReqs: -28%
  • startupPowerUserHome/longTaskTotalDuration: +12%
  • startupPowerUserHome/longTaskMaxDuration: +16%
  • startupPowerUserHome/tbt: +18%
  • startupPowerUserHome/inp: +19%
  • startupStandardHome/domInteractive: +28%
  • startupStandardHome/backgroundConnect: +21%
  • startupStandardHome/setupStore: +21%
  • startupStandardHome/fcp: +16%
  • startupPowerUserHome/backgroundConnect: -41%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 584ms
  • 🟡 startupPowerUserHome/LCP: p75 3.1s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/pwFormToMetricsScreen: +19%
  • onboardingImportWallet/doneButtonToHomeScreen: -87%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -89%
  • onboardingImportWallet/tbt: -97%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/srpButtonToPwForm: +12%
  • onboardingNewWallet/doneButtonToAssetList: -34%
  • onboardingNewWallet/longTaskCount: -55%
  • onboardingNewWallet/longTaskTotalDuration: -53%
  • onboardingNewWallet/longTaskMaxDuration: -28%
  • onboardingNewWallet/tbt: -52%
  • onboardingNewWallet/total: -30%
  • solanaAssetDetails/assetClickToPriceChart: -55%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -55%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/cls: -89%
  • importSrpHome/loginToHomeScreen: -20%
  • importSrpHome/openAccountMenuAfterLogin: +52%
  • importSrpHome/homeAfterImportWithNewWallet: -39%
  • importSrpHome/longTaskCount: -31%
  • importSrpHome/longTaskTotalDuration: -37%
  • importSrpHome/longTaskMaxDuration: -13%
  • importSrpHome/tbt: -41%
  • importSrpHome/total: -33%
  • importSrpHome/inp: -32%
  • sendTransactions/openSendPageFromHome: +20%
  • sendTransactions/selectTokenToSendFormLoaded: +40%
  • sendTransactions/inp: -23%
  • sendTransactions/cls: -89%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 102.4 KiB (1.51%)
  • ui: -41.77 KiB (-0.37%)
  • common: 389.54 KiB (2.96%)

@mathieuartu mathieuartu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 2e518f7 Jun 15, 2026
200 checks passed
@gauthierpetetin gauthierpetetin deleted the refactor/analytics-phase-b-accounts branch June 15, 2026 15:16
@metamaskbot metamaskbot added the release-13.37.0 Issue or pull request that will be included in release 13.37.0 label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-13.37.0 Issue or pull request that will be included in release 13.37.0 risk:medium size-S team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants