test(analytics): update E2E fixtures and state logs for analytics fields#43435
test(analytics): update E2E fixtures and state logs for analytics fields#43435gauthierpetetin wants to merge 3 commits into
Conversation
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (2 files, +4 -2)
🕵️ @MetaMask/extension-privacy-reviewers (1 files, +2 -2)
🧪 @MetaMask/qa (4 files, +9 -7)
|
f440266 to
ad5242b
Compare
Builds ready [ad5242b]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ad5242b to
60f17d3
Compare
Builds ready [60f17d3]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 1 fail)
Bundle size diffs
|
60f17d3 to
eb159fd
Compare
Builds ready [eb159fd] [reused from 60f17d3]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 1 fail)
Bundle size diffs
|
Co-authored-by: Cursor <cursoragent@cursor.com>
eb159fd to
0295c6e
Compare
Builds ready [0295c6e] [reused from 24c31c1]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 2 fail)
Bundle size diffs
|
There was a problem hiding this comment.
Pull request overview
Updates MetaMask Extension E2E QA artifacts (fixtures/state-log expectations and page objects) to align with the Analytics Phase B migration from legacy MetaMetrics fields to canonical analytics fields (analyticsId, optedIn, completedMetaMetricsOnboarding).
Changes:
- Update
state-logs.jsontype-map expectations to includeanalyticsId/optedInand remove some legacy metrics keys. - Rename the Privacy settings page-object toggle locator to reflect
optedIn. - Update dist E2E specs to pass
completedMetaMetricsOnboarding/optedIninto onboarding flow helpers.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/tests/settings/state-logs.json | Updates expected state-log type map for analytics-related fields. |
| test/e2e/page-objects/pages/settings/privacy-settings.ts | Renames MetaMetrics toggle selector field to optedInToggle. |
| test/e2e/dist/wallet-fixture-validation.spec.ts | Updates onboarding flow options to use canonical analytics consent fields. |
| test/e2e/dist/wallet-fixture-export.spec.ts | Updates onboarding flow options to use canonical analytics consent fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The production analytics shim still projects participateInMetaMetrics and metaMetricsId into downloaded state logs. Restore them in the type map so Firefox state-logs E2E passes until Part 14 removes the shim. Co-authored-by: Cursor <cursoragent@cursor.com>
Builds ready [cd89761] [reused from 5682526]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 6 warn · 🔴 3 fail)
Bundle size diffs
|
Description
Part 10 of the Analytics Phase B split (supersedes monolithic #43406).
Owner: @MetaMask/qa
Reason: Shared E2E fixtures and state logs still use legacy metrics field names.
Solution: Migrate fixture-builder-v2, constants, page objects, dist specs, and state-logs.json to
analyticsId,optedIn, andcompletedMetaMetricsOnboarding.Depends on: #43430
Blocks: #43439 (metrics E2E suite)
Changelog
CHANGELOG entry: null
Related issues
Part of https://github.com/MetaMask/MetaMask-planning/issues/7331
Manual testing steps
yarn build:testtest/e2e/tests/settings/state-logs.jsonexpectationsPre-merge author checklist
Pre-merge reviewer checklist