Skip to content

refactor(analytics): migrate assets defi empty state metrics#43437

Merged
gauthierpetetin merged 1 commit into
mainfrom
refactor/analytics-phase-b-assets
Jun 15, 2026
Merged

refactor(analytics): migrate assets defi empty state metrics#43437
gauthierpetetin merged 1 commit into
mainfrom
refactor/analytics-phase-b-assets

Conversation

@gauthierpetetin

@gauthierpetetin gauthierpetetin commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Part 8 of the Analytics Phase B split (supersedes monolithic #43406).

Owner: @MetaMask/metamask-assets

Reason: Defi empty state still uses legacy metrics selectors.

Solution: Update defi-empty-state.tsx to use canonical analytics selectors.

Depends on: #43430

Changelog

CHANGELOG entry: null

Related issues

Part of https://github.com/MetaMask/MetaMask-planning/issues/7331

Manual testing steps

  1. Run yarn start and verify defi empty state renders and links work with metrics enabled and disabled

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mm-token-exchange-service

mm-token-exchange-service Bot commented Jun 11, 2026

Copy link
Copy Markdown

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (1 files, +11 -6)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 defi-list/
            • 📁 cells/
              • 📄 defi-empty-state.tsx +11 -6

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [166d85e]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)

Baseline (latest main): 1ab4918 | Date: 6/11/2026 | Pipeline: 27327239488 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/inp: -17%
  • confirmTx/longTaskCount: +33%
  • confirmTx/longTaskTotalDuration: +30%
  • confirmTx/tbt: +23%
  • confirmTx/lcp: +12%
  • bridgeUserActions/bridge_load_page: -11%
  • bridgeUserActions/bridge_load_asset_picker: +14%
  • bridgeUserActions/longTaskCount: +25%
  • bridgeUserActions/longTaskTotalDuration: +28%
  • bridgeUserActions/longTaskMaxDuration: +13%
  • bridgeUserActions/tbt: +34%
  • bridgeUserActions/inp: +29%
  • loadNewAccount/load_new_account: +23%
  • loadNewAccount/total: +23%
  • loadNewAccount/inp: -17%
  • loadNewAccount/fcp: -52%
  • loadNewAccount/lcp: +1050%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -20%
  • confirmTx/fcp: -59%
  • confirmTx/lcp: +1222%
  • bridgeUserActions/bridge_load_page: +196%
  • bridgeUserActions/bridge_load_asset_picker: +15%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +28%
  • bridgeUserActions/inp: -22%
  • bridgeUserActions/fcp: -47%
  • bridgeUserActions/lcp: +1099%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/firstPaint: +16%
  • startupPowerUserHome/lcp: +14%
  • startupStandardHome/domInteractive: -11%
  • startupPowerUserHome/domInteractive: -13%
  • startupPowerUserHome/backgroundConnect: +13%
  • startupPowerUserHome/setupStore: -22%
  • startupPowerUserHome/numNetworkReqs: -13%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 528ms
  • 🟡 startupPowerUserHome/LCP: p75 3.0s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/confirmSrpToPwForm: -11%
  • onboardingImportWallet/pwFormToMetricsScreen: -13%
  • onboardingImportWallet/doneButtonToHomeScreen: -91%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -94%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -90%
  • onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +32%
  • onboardingNewWallet/doneButtonToAssetList: -21%
  • onboardingNewWallet/longTaskCount: -38%
  • onboardingNewWallet/longTaskTotalDuration: -24%
  • onboardingNewWallet/longTaskMaxDuration: -11%
  • onboardingNewWallet/tbt: -61%
  • onboardingNewWallet/total: -18%
  • assetDetails/assetClickToPriceChart: -34%
  • assetDetails/longTaskCount: +400%
  • assetDetails/longTaskTotalDuration: +333%
  • assetDetails/longTaskMaxDuration: +333%
  • assetDetails/total: -34%
  • assetDetails/inp: -34%
  • assetDetails/cls: -94%
  • solanaAssetDetails/assetClickToPriceChart: -41%
  • solanaAssetDetails/total: -41%
  • solanaAssetDetails/cls: -84%
  • importSrpHome/loginToHomeScreen: -15%
  • importSrpHome/openAccountMenuAfterLogin: +98%
  • importSrpHome/homeAfterImportWithNewWallet: -37%
  • importSrpHome/longTaskCount: -24%
  • importSrpHome/longTaskTotalDuration: -24%
  • importSrpHome/longTaskMaxDuration: -17%
  • importSrpHome/tbt: -38%
  • importSrpHome/total: -29%
  • importSrpHome/inp: -43%
  • importSrpHome/cls: -40%
  • sendTransactions/openSendPageFromHome: +26%
  • sendTransactions/selectTokenToSendFormLoaded: +53%
  • sendTransactions/reviewTransactionToConfirmationPage: +17%
  • sendTransactions/longTaskCount: +11%
  • sendTransactions/longTaskTotalDuration: +21%
  • sendTransactions/tbt: +40%
  • sendTransactions/total: +16%
  • sendTransactions/inp: -27%
  • sendTransactions/fcp: +18%
  • sendTransactions/cls: -87%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 sendTransactions/FCP: p75 2.1s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -26%
  • dappPageLoad/domContentLoaded: -21%
  • dappPageLoad/firstPaint: -17%
  • dappPageLoad/firstContentfulPaint: -17%
Bundle size diffs
  • background: 245 Bytes (0%)
  • ui: 50 Bytes (0%)
  • common: 188 Bytes (0%)

Base automatically changed from refactor/analytics-phase-b-foundation to main June 11, 2026 14:49
@gauthierpetetin gauthierpetetin force-pushed the refactor/analytics-phase-b-assets branch from 166d85e to 676a406 Compare June 11, 2026 14:53
@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [676a406]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 7 warn · 🔴 1 fail)

Baseline (latest main): 86afca4 | Date: 6/11/2026 | Pipeline: 27355755300 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -26%
  • loadNewAccount/total: -26%
  • loadNewAccount/inp: +23%
  • loadNewAccount/cls: -17%
  • confirmTx/tbt: -13%
  • confirmTx/inp: +63%
  • bridgeUserActions/bridge_load_page: -15%
  • bridgeUserActions/bridge_load_asset_picker: -16%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -25%
  • bridgeUserActions/longTaskMaxDuration: -12%
  • bridgeUserActions/tbt: -41%
  • bridgeUserActions/inp: -15%
  • loadNewAccount/load_new_account: +21%
  • loadNewAccount/total: +21%
  • loadNewAccount/fcp: -51%
  • loadNewAccount/lcp: +1568%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/fcp: -50%
  • confirmTx/lcp: +1164%
  • bridgeUserActions/bridge_load_page: +172%
  • bridgeUserActions/bridge_load_asset_picker: +36%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/inp: -39%
  • bridgeUserActions/fcp: -50%
  • bridgeUserActions/lcp: +1193%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: +42%
  • startupStandardHome/inp: +100%
  • startupPowerUserHome/backgroundConnect: +19%
  • startupPowerUserHome/setupStore: -16%
  • startupPowerUserHome/numNetworkReqs: +14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 520ms
  • 🟡 startupPowerUserHome/LCP: p75 3.3s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +10%
  • onboardingImportWallet/confirmSrpToPwForm: +11%
  • onboardingImportWallet/pwFormToMetricsScreen: +11%
  • onboardingImportWallet/metricsToWalletReadyScreen: +15%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -72%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -90%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/skipBackupToMetricsScreen: +10%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +23%
  • onboardingNewWallet/doneButtonToAssetList: -20%
  • onboardingNewWallet/longTaskCount: -44%
  • onboardingNewWallet/longTaskTotalDuration: -47%
  • onboardingNewWallet/longTaskMaxDuration: -13%
  • onboardingNewWallet/tbt: -51%
  • onboardingNewWallet/total: -17%
  • solanaAssetDetails/assetClickToPriceChart: -62%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -62%
  • solanaAssetDetails/cls: -93%
  • importSrpHome/loginToHomeScreen: -16%
  • importSrpHome/openAccountMenuAfterLogin: +29%
  • importSrpHome/homeAfterImportWithNewWallet: -35%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -24%
  • importSrpHome/tbt: -20%
  • importSrpHome/total: -32%
  • importSrpHome/inp: -32%
  • importSrpHome/fcp: +11%
  • sendTransactions/openSendPageFromHome: +27%
  • sendTransactions/selectTokenToSendFormLoaded: +29%
  • sendTransactions/tbt: +23%
  • sendTransactions/inp: -29%
  • sendTransactions/lcp: -15%
  • sendTransactions/cls: -73%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 246 Bytes (0%)
  • ui: 50 Bytes (0%)
  • common: 188 Bytes (0%)

@metamaskbotv2

metamaskbotv2 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ace2ac2] [reused from 676a406]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 7 warn · 🔴 1 fail)

Baseline (latest main): 86afca4 | Date: 6/11/2026 | Pipeline: 27360423153 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -26%
  • loadNewAccount/total: -26%
  • loadNewAccount/inp: +23%
  • loadNewAccount/cls: -17%
  • confirmTx/tbt: -13%
  • confirmTx/inp: +63%
  • bridgeUserActions/bridge_load_page: -15%
  • bridgeUserActions/bridge_load_asset_picker: -16%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -25%
  • bridgeUserActions/longTaskMaxDuration: -12%
  • bridgeUserActions/tbt: -41%
  • bridgeUserActions/inp: -15%
  • loadNewAccount/load_new_account: +21%
  • loadNewAccount/total: +21%
  • loadNewAccount/fcp: -51%
  • loadNewAccount/lcp: +1568%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/fcp: -50%
  • confirmTx/lcp: +1164%
  • bridgeUserActions/bridge_load_page: +172%
  • bridgeUserActions/bridge_load_asset_picker: +36%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/inp: -39%
  • bridgeUserActions/fcp: -50%
  • bridgeUserActions/lcp: +1193%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: +42%
  • startupStandardHome/inp: +100%
  • startupPowerUserHome/backgroundConnect: +19%
  • startupPowerUserHome/setupStore: -16%
  • startupPowerUserHome/numNetworkReqs: +14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 520ms
  • 🟡 startupPowerUserHome/LCP: p75 3.3s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +10%
  • onboardingImportWallet/confirmSrpToPwForm: +11%
  • onboardingImportWallet/pwFormToMetricsScreen: +11%
  • onboardingImportWallet/metricsToWalletReadyScreen: +15%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -72%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -90%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/skipBackupToMetricsScreen: +10%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +23%
  • onboardingNewWallet/doneButtonToAssetList: -20%
  • onboardingNewWallet/longTaskCount: -44%
  • onboardingNewWallet/longTaskTotalDuration: -47%
  • onboardingNewWallet/longTaskMaxDuration: -13%
  • onboardingNewWallet/tbt: -51%
  • onboardingNewWallet/total: -17%
  • solanaAssetDetails/assetClickToPriceChart: -62%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -62%
  • solanaAssetDetails/cls: -93%
  • importSrpHome/loginToHomeScreen: -16%
  • importSrpHome/openAccountMenuAfterLogin: +29%
  • importSrpHome/homeAfterImportWithNewWallet: -35%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -24%
  • importSrpHome/tbt: -20%
  • importSrpHome/total: -32%
  • importSrpHome/inp: -32%
  • importSrpHome/fcp: +11%
  • sendTransactions/openSendPageFromHome: +27%
  • sendTransactions/selectTokenToSendFormLoaded: +29%
  • sendTransactions/tbt: +23%
  • sendTransactions/inp: -29%
  • sendTransactions/lcp: -15%
  • sendTransactions/cls: -73%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 50 Bytes (0%)
  • common: 20 Bytes (0%)

Refresh slice from main-synced monolithic branch.
@metamaskbotv2

metamaskbotv2 Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [02f7faa]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)

Baseline (latest main): 5befce5 | Date: 6/12/2026 | Pipeline: 27394672780 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -35%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: -35%
  • loadNewAccount/lcp: -68%
  • confirmTx/longTaskTotalDuration: -17%
  • confirmTx/longTaskMaxDuration: -11%
  • confirmTx/tbt: -24%
  • confirmTx/inp: -11%
  • bridgeUserActions/tbt: +12%
  • bridgeUserActions/inp: -23%
  • bridgeUserActions/lcp: -14%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/inp: -32%
  • loadNewAccount/lcp: +319%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -20%
  • confirmTx/lcp: +1074%
  • bridgeUserActions/bridge_load_page: +41%
  • bridgeUserActions/bridge_load_asset_picker: +94%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +170%
  • bridgeUserActions/lcp: +1039%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/domInteractive: -12%
  • startupPowerUserHome/setupStore: -13%
  • startupStandardHome/domInteractive: -12%
  • startupStandardHome/inp: +25%
  • startupStandardHome/fcp: -12%
  • startupPowerUserHome/backgroundConnect: +35%
  • startupPowerUserHome/setupStore: +14%
  • startupPowerUserHome/numNetworkReqs: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 528ms
  • 🟡 startupPowerUserHome/LCP: p75 2.8s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -90%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -71%
  • onboardingImportWallet/longTaskTotalDuration: -85%
  • onboardingImportWallet/longTaskMaxDuration: -78%
  • onboardingImportWallet/tbt: -94%
  • onboardingImportWallet/total: -88%
  • onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • onboardingNewWallet/doneButtonToAssetList: -21%
  • onboardingNewWallet/longTaskCount: -55%
  • onboardingNewWallet/longTaskTotalDuration: -54%
  • onboardingNewWallet/tbt: -52%
  • onboardingNewWallet/total: -17%
  • solanaAssetDetails/assetClickToPriceChart: -47%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/total: -47%
  • solanaAssetDetails/inp: +16%
  • solanaAssetDetails/lcp: +11%
  • solanaAssetDetails/cls: -92%
  • importSrpHome/openAccountMenuAfterLogin: +30%
  • importSrpHome/homeAfterImportWithNewWallet: -32%
  • importSrpHome/longTaskCount: -18%
  • importSrpHome/longTaskTotalDuration: -18%
  • importSrpHome/tbt: -17%
  • importSrpHome/total: -25%
  • importSrpHome/inp: -23%
  • sendTransactions/openSendPageFromHome: +100%
  • sendTransactions/selectTokenToSendFormLoaded: +28%
  • sendTransactions/inp: -33%
  • sendTransactions/cls: -89%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 50 Bytes (0%)
  • common: 20 Bytes (0%)

@gauthierpetetin gauthierpetetin marked this pull request as ready for review June 15, 2026 03:38
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner June 15, 2026 03:38
@gauthierpetetin gauthierpetetin requested a review from Copilot June 15, 2026 03:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the DeFi empty state component off legacy MetaMetrics selectors to the Phase B canonical analytics selectors, aligning consent gating with AnalyticsController-backed state.

Changes:

  • Replaces getMetaMetricsId / getParticipateInMetaMetrics usage with getAnalyticsId, getCompletedMetaMetricsOnboarding, and getOptedIn.
  • Derives isMetaMetricsEnabled from completedMetaMetricsOnboarding && isOptedIn and continues to pass the consent booleans into getPortfolioUrl.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit b033547 Jun 15, 2026
202 checks passed
@gauthierpetetin gauthierpetetin deleted the refactor/analytics-phase-b-assets branch June 15, 2026 20:44
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 15, 2026
@metamaskbot metamaskbot added the release-13.37.0 Issue or pull request that will be included in release 13.37.0 label Jun 15, 2026
georgewrmarshall pushed a commit that referenced this pull request Jun 16, 2026
## **Description**

Part 8 of the Analytics Phase B split (supersedes monolithic #43406).

**Owner:** @MetaMask/metamask-assets

**Reason:** Defi empty state still uses legacy metrics selectors.

**Solution:** Update `defi-empty-state.tsx` to use canonical analytics
selectors.

**Depends on:** #43430

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Part of MetaMask/MetaMask-planning#7331

## **Manual testing steps**

1. Run `yarn start` and verify defi empty state renders and links work
with metrics enabled and disabled

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-13.37.0 Issue or pull request that will be included in release 13.37.0 risk:high size-S team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants