test(analytics): update snaps E2E for analytics fixtures#43438
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (3 files, +35 -28)
|
26ec1cc to
c8b0efa
Compare
Builds ready [c8b0efa]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
c8b0efa to
2c10572
Compare
Builds ready [2c10572]
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
2c10572 to
4180c9f
Compare
Builds ready [4180c9f] [reused from 2c10572]
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
Refresh slice from main-synced monolithic branch.
4180c9f to
2f3bc18
Compare
Builds ready [2f3bc18] [reused from 24c31c1]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 2 fail)
Bundle size diffs
|
There was a problem hiding this comment.
Pull request overview
Updates Snaps E2E specs to use the canonical analytics fixture fields introduced in the Analytics Phase B refactor, replacing legacy metaMetricsId / participateInMetaMetrics usage in these tests.
Changes:
- Replace
MOCK_META_METRICS_IDusage withMOCK_ANALYTICS_IDin Snaps E2E tests. - Update fixtures to set
analyticsId,optedIn, andcompletedMetaMetricsOnboardinginstead of legacy MetaMetrics fields. - Normalize imports in the Flask Snaps E2E spec to reference the new constant.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/e2e/snaps/test-snap-metrics.spec.ts | Migrates Snap metrics E2E fixtures/constants to canonical analytics fields. |
| test/e2e/snaps/test-snap-installed.spec.ts | Updates Snap installed E2E fixture to canonical analytics fields. |
| test/e2e/flask/snaps/preinstalled-example.spec.ts | Updates Flask snap E2E fixture fields + constants import to canonical analytics fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Part 9 of the Analytics Phase B split (supersedes monolithic #43406).
Owner: @MetaMask/core-platform
Reason: Snaps E2E specs still use legacy metrics fixture fields.
Solution: Update snaps E2E specs for canonical analytics fixture fields.
Depends on: #43430
Changelog
CHANGELOG entry: null
Related issues
Part of https://github.com/MetaMask/MetaMask-planning/issues/7331
Manual testing steps
yarn build:testPre-merge author checklist
Pre-merge reviewer checklist